Fix: passing a non-JSON string to terratag should not panic #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaronya
reviewed
Apr 24, 2022
main.go
Outdated
| if err != nil { | ||
| log.Printf("[ERROR] Invalid input tags! must be a valid JSON.\nInput: %s\nError: %s\n", tags, err.Error()) | ||
| os.Exit(1) | ||
| } | ||
| PanicOnError(err, nil) |
There was a problem hiding this comment.
Does this make this line redundant?
There was a problem hiding this comment.
@yaronya - yes. thanks for pointing it out. Removed.
TomerHeber
force-pushed
the
fix-invalid-json-not-panic-#120
branch
from
c48491d
to
ca247fd
Compare
TomerHeber
commented
Apr 24, 2022
| @@ -162,7 +162,10 @@ func tagFileResources(path string, dir string, filter string, tags string, tfVer | |||
| func jsonToHclMap(tags string) string { | |||
| var tagsMap map[string]string | |||
| err := json.Unmarshal([]byte(tags), &tagsMap) | |||
| PanicOnError(err, nil) | |||
There was a problem hiding this comment.
line removed....
TomerHeber
force-pushed
the
fix-invalid-json-not-panic-#120
branch
from
ca247fd
to
f1ce56e
Compare
HeverFarber
approved these changes
Apr 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Print a log message and exit(1) instead.