Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: support aliased provider names #67

Merged
merged 2 commits into from
Nov 4, 2020
Merged

Fix: support aliased provider names #67

merged 2 commits into from
Nov 4, 2020

Conversation

yaronya
Copy link
Contributor

@yaronya yaronya commented Nov 4, 2020

fixes #66

Solution

Instead of having a generic solution that captures every custom provider name specified, we'll support a pre-defined set of providers, currently containing only google-beta.

@yaronya yaronya requested a review from a team November 4, 2020 14:04
@yaronya yaronya self-assigned this Nov 4, 2020
@yaronya yaronya removed the request for review from a team November 4, 2020 14:04
@yaronya yaronya requested a review from a team November 4, 2020 14:09
roni-frantchi
roni-frantchi approved these changes Nov 4, 2020
View reviewed changes
Copy link
Contributor

@roni-frantchi roni-frantchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@yaronya yaronya merged commit 006dbd6 into master Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roni-frantchi roni-frantchi roni-frantchi approved these changes

@shlomimatichin shlomimatichin Awaiting requested review from shlomimatichin

Assignees

@yaronya yaronya

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tfschema client fails on initializing aliased provider names
2 participants
@yaronya @roni-frantchi