Fix: New lines in modified attributes #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 4b930d0.
yaronya
reviewed
Jan 14, 2021
| default = {} | ||
| } | ||
|
|
||
| resource "aws_s3_bucket" "example" { |
There was a problem hiding this comment.
@avnerenv0 is there any special reason why tf12 scenario/tests are different than tf11? 🤔
There was a problem hiding this comment.
just because the interpolation syntax "${...}" I wanted to make sure it works as expected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #71
Instead of inserting our modified tags as a string,
We will pass them through HCL Parse and insert them as raw tokens.
That way newlines are inserted correctly instead of as
\n