Support Terraform 1.0.0 #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avnerenv0
approved these changes
Jun 16, 2021
Comment on lines
+53
to
+65
| - name: Set Test-Suite | ||
| id: test-suite | ||
| env: | ||
| TF_VERSION: ${{ matrix.terraform_version }} | ||
| uses: actions/github-script@v4 | ||
| with: | ||
| script: | | ||
| console.log(`Setting test suite version based on ${process.env.TF_VERSION}`) | ||
| const suite = process.env.TF_VERSION.replace('.', 'o') | ||
| console.log(`Test suite set to ${suite}`) | ||
| return suite | ||
| result-encoding: string | ||
|
|
Comment on lines
+47
to
+51
| testTerraform(t, "15_1.0") | ||
| } | ||
|
|
||
| func TestTerraform1o0(t *testing.T) { | ||
| testTerraform(t, "15_1.0") |
There was a problem hiding this comment.
how come the tests for 1 and 15 are the same?
There was a problem hiding this comment.
We do the same between 13 and 14.
Basically nothing has changed in terms of in/out syntax and no new cases, so we reuse the fixture files
| func buildMapExpression(tokens hclwrite.Tokens, tfVersion int) string { | ||
| if tfVersion >= 15 { | ||
| func buildMapExpression(tokens hclwrite.Tokens, tfVersion Version) string { | ||
| if tfVersion.Major == 0 && tfVersion.Minor >= 15 || tfVersion.Major == 1 { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #89