Test against Rails 6.1 #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@andyjdavis thank you so much for doing this! Should it not test for 6.0 and 6.1? |
Seems like a good idea @ssunday I have expanded Travis.yml to run the tests against both 6.0 and 6.1 |
|
@orien Hi! Is there anything we can do to help move this forward? Thanks! 😁 |
stevend
approved these changes
Jul 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a potential fix for #200
The tests pass locally before and after these changes but that isn't surprising given the nature of the changes.
https://railsbump.org/gems/double_entry claims 6.1 is fine. Waiting to see the result of the Travis run. I'm not entirely sure how else to validate this so if this isn't correct or more needs doing let me know :)