Travis CI enabled #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joesustaric
reviewed
Nov 12, 2018
| @@ -1,5 +1,8 @@ | |||
| sudo: false | |||
| language: ruby | |||
| rvm: | |||
| - 2.4.2 | |||
| before_install: gem install bundler -v 1.16.1 | |||
| - 2.4.5 | |||
There was a problem hiding this comment.
no 2.3 or 2.2 ? I think that if this project is trying to promote better gem lib freshness.. I would suspect those projects might be not so fresh with their ruby versions as well.. just a thought..
joesustaric
approved these changes
Nov 12, 2018
joesustaric
reviewed
Nov 12, 2018
.travis.yml
Outdated
| - 2.5.3 | ||
| before_install: | ||
| - gem update --system | ||
| - gem install bundler -v 1.17.1 |
There was a problem hiding this comment.
Why do we need to specify the version of bundler?
There was a problem hiding this comment.
We don't. Addressed in 0e090f3.
orien
approved these changes
Nov 12, 2018
| @@ -16,7 +16,7 @@ to get regular dependency updates into production. | |||
| - Vulnerability advisory information using [bundler-audit](https://github.com/rubysec/bundler-audit) | |||
| - Links to the home page, source code and change log (where available) of each gem | |||
|
|
|||
| ## Development status [](https://buildkite.com/envato-marketplaces/unwrappr) | |||
| ## Development status [](https://travis-ci.org/envato/unwrappr) | |||
There was a problem hiding this comment.
I'd be nice if they had a flat style like the other badges in the readme.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Since we released to RubyGems, a few little niggles have appeared.
Change
Considerations
Will release as 0.3.1
Cc
@orien, @joesustaric