Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI via GitHub actions #78

Merged
merged 8 commits into from
Dec 17, 2020
Merged

CI via GitHub actions #78

merged 8 commits into from
Dec 17, 2020

Conversation

johnsyweb
Copy link
Contributor

Context

With wait times getting longer on our previous CI provider, we have decided to use GitHub Actions for our open-source projects.

Change

  • Defined CI/Test action in .github/workflows/ci.yml
  • Addressed stylistic issues with Rubocop

@johnsyweb johnsyweb requested a review from orien December 17, 2020 03:18
orien
orien approved these changes Dec 17, 2020
View reviewed changes
Copy link
Member

@orien orien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

joesustaric
joesustaric approved these changes Dec 17, 2020
View reviewed changes
Copy link
Contributor

@joesustaric joesustaric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

@johnsyweb johnsyweb merged commit b86de84 into master Dec 17, 2020
@johnsyweb johnsyweb deleted the paj/github-actions branch December 17, 2020 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orien orien orien approved these changes

@joesustaric joesustaric joesustaric approved these changes

@Domon Domon Domon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@johnsyweb @Domon @joesustaric @orien