Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the CI build: Rubocop fixes #92

Merged
merged 12 commits into from
Aug 8, 2022
Merged

Fix the CI build: Rubocop fixes #92

merged 12 commits into from
Aug 8, 2022

Conversation

orien
Copy link
Member

@orien orien commented Aug 6, 2022

Context

The main CI build is failing in response to new checks introduced in the latest versions of Rubocop.

Change

  • Resolve issues raised by Rubocop
  • Fix a test that was failing on Ruby 3.0
  • Run the test suite on Ruby 3.1 during the CI build
  • Simplify the CI setup

I recommend running through the changes commit-by-commit for context.

/cc @johnsyweb @joesustaric @domon-envato

Copy link
Contributor

@johnsyweb johnsyweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for picking this up!

unwrappr.gemspec Outdated Show resolved Hide resolved
@client ||= Client.new(access_token: access_token_from_environment)
end

def self.access_token_from_environment
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice extraction!

Co-authored-by: Pete Johns <pete@johnsy.com>
@orien orien merged commit c58aa78 into main Aug 8, 2022
@orien orien deleted the ci branch August 8, 2022 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants