Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: add Ruby 3.2 to the RSpec test matrix #93

Merged
merged 3 commits into from
Feb 6, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
@@ -7,10 +7,10 @@ jobs:
strategy:
fail-fast: false
matrix:
ruby: ['2.5', '2.6', '2.7', '3.0', '3.1']
ruby: ['2.5', '2.6', '2.7', '3.0', '3.1', '3.2']
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
- uses: ruby/setup-ruby@v1
with:
ruby-version: ${{ matrix.ruby }}
1 change: 1 addition & 0 deletions .rubocop.yml
Original file line number Diff line number Diff line change
@@ -4,6 +4,7 @@ AllCops:
- 'spike/*.rb'
- 'vendor/**/*'
NewCops: enable
SuggestExtensions: false
TargetRubyVersion: 2.5

Gemspec/RequiredRubyVersion:
2 changes: 1 addition & 1 deletion lib/unwrappr/lock_file_diff.rb
Original file line number Diff line number Diff line change
@@ -63,7 +63,7 @@ def extract_gem_and_change_type(line)
# '+ websocket-driver (0.6.5)'
# Careful not to match this (note the wider indent):
# '+ websocket-extensions (>= 0.1.0)'
pattern = /^(?<change_type>[+\-]) (?<gem_name>\S+) \(\d/
pattern = /^(?<change_type>[+-]) (?<gem_name>\S+) \(\d/
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A fix for a Rubocop issue: resolve Style/RedundantRegexpEscape.

match = pattern.match(line)
return match[:gem_name], match[:change_type] unless match.nil?
end