fix: transaction filtering by direction and type #1101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1101 +/- ##
==========================================
+ Coverage 81.20% 81.29% +0.08%
==========================================
Files 54 54
Lines 4890 4913 +23
==========================================
+ Hits 3971 3994 +23
Misses 775 775
Partials 144 144 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Transaction filtering was incomplete and wrong so far, which is fixed with this change. There are now two different filters, direction and type. direction filters by the source/destination accounts being internal or external. It has the following values: - IN: Transaction from an external to an internal account - OUT: Transaction from an internal account to an external account - INTERNAL: Transaction from an internal to an internal account (same as the old direction: TRANSFER) type filters by the effect a transaction has on the budget. It has the following values - INCOME: From an off-budget to an on-budget account (same as the old direction: INCOMING) - SPEND: From an on-budget to an off-budget account (same as the old direction: OUTGOING) - TRANSFER: From an on-budget to an on-budget account
morremeyer
force-pushed
the
fix/transaction-filtering
branch
from
8900c4d to
97d637e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transaction filtering was incomplete and wrong so far, which is fixed with this change.
There are now two different filters, direction and type.
direction filters by the source/destination accounts being internal or external. It has the following values:
type filters by the effect a transaction has on the budget. It has the following values
Resolves #1024.