Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: match rules are now called match rules and follow API v2 specification #787

Merged
merged 1 commit into from
Oct 8, 2023

Conversation

morremeyer
Copy link
Member

This deprecates the /v2/rename-rules endpoint and introduces
/v2/match-rules with the correct API semantics.

Resolves #763.

…cation

This deprecates the `/v2/rename-rules` endpoint and introduces
`/v2/match-rules` with the correct API semantics.
@morremeyer morremeyer requested a review from a team as a code owner October 8, 2023 10:55
@codecov
Copy link

codecov bot commented Oct 8, 2023

Codecov Report

Attention: 144 lines in your changes are missing coverage. Please review.

Comparison is base (e823490) 84.85% compared to head (1634a4e) 81.72%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #787      +/-   ##
==========================================
- Coverage   84.85%   81.72%   -3.14%     
==========================================
  Files          36       37       +1     
  Lines        3546     3710     +164     
==========================================
+ Hits         3009     3032      +23     
- Misses        438      578     +140     
- Partials       99      100       +1     
Files Coverage Δ
pkg/controllers/budget.go 65.29% <ø> (ø)
pkg/controllers/import.go 81.65% <100.00%> (+0.66%) ⬆️
pkg/router/router.go 87.05% <100.00%> (+0.18%) ⬆️
pkg/models/match_rule.go 20.00% <33.33%> (ø)
pkg/models/database.go 62.82% <16.66%> (-4.31%) ⬇️
pkg/controllers/rename_rule.go 8.72% <0.00%> (-14.10%) ⬇️
pkg/controllers/match_rule.go 22.81% <22.81%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@morremeyer morremeyer merged commit 68ebbb9 into main Oct 8, 2023
6 checks passed
@morremeyer morremeyer deleted the fix/match-rules branch October 8, 2023 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

match rules don't follow API v2 conventions
1 participant