Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: availability date is now enforced to not be earlier than the month of the transaction #789

Merged
merged 1 commit into from
Oct 8, 2023

Conversation

morremeyer
Copy link
Member

Resolves #768.

@morremeyer morremeyer requested a review from a team as a code owner October 8, 2023 13:28
@codecov
Copy link

codecov bot commented Oct 8, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (8f108f1) 81.72% compared to head (9408714) 81.73%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #789   +/-   ##
=======================================
  Coverage   81.72%   81.73%           
=======================================
  Files          37       37           
  Lines        3711     3713    +2     
=======================================
+ Hits         3033     3035    +2     
  Misses        578      578           
  Partials      100      100           
Files Coverage Δ
pkg/models/transaction.go 94.33% <100.00%> (+0.22%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@morremeyer morremeyer merged commit 34d3180 into main Oct 8, 2023
6 checks passed
@morremeyer morremeyer deleted the fix/available-from-before-transaction branch October 8, 2023 13:31
morremeyer added a commit to envelope-zero/frontend that referenced this pull request Oct 12, 2023
…tion

The backend enforces the availability date to be no earlier than the month of the
transaction from version v3.1.4 on with envelope-zero/backend#789.

The frontend does not set this correctly yet when duplicating transactions.

This PR fixes that behavior.
morremeyer added a commit to envelope-zero/frontend that referenced this pull request Oct 12, 2023
…tion (#1180)

The backend enforces the availability date to be no earlier than the month of the
transaction from version v3.1.4 on with envelope-zero/backend#789.

The frontend does not set this correctly yet when duplicating transactions.

This PR fixes that behavior.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

availableFrom can be set before transaction date
1 participant