fix: income now recognized in RecentEnvelopes and transaction import #790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The RecentEnvelopes field for Account resources and the proposed Envelope for ImportPreviews now also consider income transactions. Income is represented as the nil UUID in the Envelope ID, meaning that the RecentEnvelopes field will contain an entry with all zero-values for Income. This will be improved in API v2 to replace the ID for income with a `null` value.
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #790 +/- ##
==========================================
+ Coverage 81.73% 81.85% +0.12%
==========================================
Files 37 37
Lines 3713 3710 -3
==========================================
+ Hits 3035 3037 +2
+ Misses 578 574 -4
+ Partials 100 99 -1
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RecentEnvelopes field for Account resources and the proposed Envelope for
ImportPreviews now also consider income transactions.
Income is represented as the nil UUID in the Envelope ID, meaning that the
RecentEnvelopes field will contain an entry with all zero-values for Income.
This will be improved in API v2 to replace the ID for income with a
nullvalue.Resolves #773.