fix: transaction sorting now takes time of day and creation time into account #834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… account Before this fix, transactions would be sorted correctly by date, but transactions later in a day would be after transactions earlier in the day. When transactions were added for the exact same time (typically when importing), sorting was undefined. Sorting for transactions at the same time now is "newest first" by creation time, putting transactions added later earlier in the list. Since the sorting is "newest first", this was wrong. Sorting takes place with second precision, meaning that any sub-second differences are ignored in sorting. This is a limitation of the sqlite `datetime` function.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #834 +/- ##
=======================================
Coverage 81.11% 81.11%
=======================================
Files 41 41
Lines 4029 4029
=======================================
Hits 3268 3268
Misses 627 627
Partials 134 134
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this fix, transactions would be sorted correctly by date, but
transactions later in a day would be after transactions earlier in the day.
When transactions were added for the exact same time (typically when importing),
sorting was undefined. Sorting for transactions at the same time now is "newest first"
by creation time, putting transactions added later earlier in the list.
Since the sorting is "newest first", this was wrong.
Sorting takes place with second precision, meaning that any sub-second differences
are ignored in sorting. This is a limitation of the sqlite
datetimefunction.