Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: define all errors as variables #837

Merged
merged 1 commit into from
Nov 12, 2023
Merged

Conversation

morremeyer
Copy link
Member

This defines the remaining errors in the httperrors package as exported variables.

@morremeyer morremeyer requested a review from a team as a code owner November 12, 2023 19:23
This defines the remaining errors in the httperrors package as exported variables.
Copy link

codecov bot commented Nov 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (414e71d) 81.52% compared to head (373cb0d) 81.52%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #837   +/-   ##
=======================================
  Coverage   81.52%   81.52%           
=======================================
  Files          42       42           
  Lines        4282     4282           
=======================================
  Hits         3491     3491           
  Misses        653      653           
  Partials      138      138           
Files Coverage Δ
pkg/httperrors/errors.go 90.22% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@morremeyer morremeyer merged commit 0878cda into main Nov 12, 2023
6 checks passed
@morremeyer morremeyer deleted the refactor/errors branch November 12, 2023 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant