Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add POST method for /v3/transactions #838

Merged
merged 1 commit into from
Nov 12, 2023

Conversation

morremeyer
Copy link
Member

With this, API v3 supports transaction creation.

@morremeyer morremeyer requested a review from a team as a code owner November 12, 2023 20:36
Copy link

codecov bot commented Nov 12, 2023

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (0878cda) 81.52% compared to head (2574d94) 81.59%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #838      +/-   ##
==========================================
+ Coverage   81.52%   81.59%   +0.06%     
==========================================
  Files          42       42              
  Lines        4282     4336      +54     
==========================================
+ Hits         3491     3538      +47     
- Misses        653      659       +6     
- Partials      138      139       +1     
Files Coverage Δ
pkg/controllers/account_v1.go 80.00% <100.00%> (ø)
pkg/controllers/allocation.go 88.67% <100.00%> (ø)
pkg/controllers/category.go 88.88% <100.00%> (ø)
pkg/controllers/envelope.go 88.35% <100.00%> (ø)
pkg/controllers/month.go 86.84% <100.00%> (ø)
pkg/controllers/month_config.go 91.12% <100.00%> (ø)
pkg/controllers/transaction_v1.go 91.38% <100.00%> (ø)
pkg/controllers/transaction_v2.go 88.46% <100.00%> (ø)
pkg/httperrors/errors.go 90.22% <ø> (ø)
pkg/httputil/request.go 75.00% <100.00%> (+10.29%) ⬆️
... and 5 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

With this, API v3 supports transaction creation.
@morremeyer morremeyer force-pushed the feat/v3-transactions-create branch from 81eb4e7 to 2574d94 Compare November 12, 2023 20:54
@morremeyer morremeyer merged commit 554fdd6 into main Nov 12, 2023
6 checks passed
@morremeyer morremeyer deleted the feat/v3-transactions-create branch November 12, 2023 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant