Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove reconciled field in API v3 responses #853

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

morremeyer
Copy link
Member

This removes the deprecated field from API v3 responses, where it should not have appeared in the first place.

It can still be used in requests, but will not have any effect since the field is ignored.

@morremeyer morremeyer requested a review from a team as a code owner November 22, 2023 11:26
@morremeyer morremeyer enabled auto-merge (squash) November 22, 2023 11:26
Copy link

codecov bot commented Nov 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (06e24ce) 81.51% compared to head (7f4434d) 81.51%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #853   +/-   ##
=======================================
  Coverage   81.51%   81.51%           
=======================================
  Files          44       44           
  Lines        4821     4821           
=======================================
  Hits         3930     3930           
  Misses        737      737           
  Partials      154      154           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@morremeyer morremeyer merged commit de90ca1 into main Nov 22, 2023
6 checks passed
@morremeyer morremeyer deleted the fix/remove-reconciled branch November 22, 2023 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant