Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add import endpoints for API v3 #854

Merged
merged 1 commit into from
Nov 23, 2023
Merged

feat: add import endpoints for API v3 #854

merged 1 commit into from
Nov 23, 2023

Conversation

morremeyer
Copy link
Member

This adds the /v3/import route and its components (YNAB4 and YNAB Import)

@morremeyer morremeyer requested a review from a team as a code owner November 23, 2023 10:35
Copy link

codecov bot commented Nov 23, 2023

Codecov Report

Attention: 56 lines in your changes are missing coverage. Please review.

Comparison is base (de90ca1) 81.51% compared to head (e318102) 81.60%.

Files Patch % Lines
pkg/controllers/import_v3.go 80.62% 26 Missing and 5 partials ⚠️
pkg/controllers/import_v1.go 84.49% 15 Missing and 5 partials ⚠️
pkg/httperrors/errors.go 0.00% 2 Missing and 1 partial ⚠️
pkg/controllers/import.go 84.61% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #854      +/-   ##
==========================================
+ Coverage   81.51%   81.60%   +0.08%     
==========================================
  Files          44       46       +2     
  Lines        4821     5001     +180     
==========================================
+ Hits         3930     4081     +151     
- Misses        737      761      +24     
- Partials      154      159       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@morremeyer morremeyer merged commit 375dc49 into main Nov 23, 2023
6 checks passed
@morremeyer morremeyer deleted the feat/v3-import branch November 23, 2023 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant