Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add /v3/budgets endpoints #858

Merged
merged 1 commit into from
Nov 26, 2023
Merged

feat: add /v3/budgets endpoints #858

merged 1 commit into from
Nov 26, 2023

Conversation

morremeyer
Copy link
Member

This adds support for Budgets to the v3 API

@morremeyer morremeyer requested a review from a team as a code owner November 26, 2023 17:13
Copy link

codecov bot commented Nov 26, 2023

Codecov Report

Attention: 73 lines in your changes are missing coverage. Please review.

Comparison is base (fb87739) 81.60% compared to head (e386e05) 81.21%.

Files Patch % Lines
pkg/controllers/budget_v3.go 75.09% 58 Missing and 10 partials ⚠️
pkg/controllers/import_v3.go 16.66% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #858      +/-   ##
==========================================
- Coverage   81.60%   81.21%   -0.40%     
==========================================
  Files          46       47       +1     
  Lines        5001     5280     +279     
==========================================
+ Hits         4081     4288     +207     
- Misses        761      823      +62     
- Partials      159      169      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This adds support for Budgets to the v3 API
@morremeyer morremeyer mentioned this pull request Nov 26, 2023
25 tasks
@morremeyer morremeyer merged commit 86ec4cb into main Nov 26, 2023
6 checks passed
@morremeyer morremeyer deleted the feat/v3-budgets branch November 26, 2023 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant