-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow selection with vi keys #46
Conversation
when the VISUAL environment variable is set.
You beat me to it 😅. Thank you @afh |
Sorry about that 😉 |
@afh That sounds like a great idea! I'll definitely show my support Also I updated your implementation to accept a boolean value only, since currently the user just has to pass the |
@humblepenguinn the |
@afh, well in that case And neither does inquire, require a visual editor argument but rather a boolean value ( What do you say? |
Quickly reading up on Not sure how to detect if the shell has its vi mode enabled, e.g. zsh: 🤔 |
Perhaps we can parse the output of the following command: However, I don't see why we need to keep the The Emacs key bindings in the inquire crate are already enabled by default, so we can't provide users the option to opt out from there. Thus, right now, we just need a way to figure out if the user wants vim_mode enabled or not. I think we should change the name of the environment variable to |
I think I have an idea on how to approach this. Expect a PR soon 🙂 |
Please have a look at #53 🙂 Possibly the proposed changes are trying to be too clever, but introducing yet another configuration environment variable specific to a single program does not feel right either… |
when the VISUAL environment variable is set.
What are your thoughts on this, @humblepenguinn, for a first attempt to please long time vi-users, who mostly deleted the cursor keys from the muscle memory?