Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to react-ocean-forms 3.0.0 #93

Open
wants to merge 36 commits into
base: master
Choose a base branch
from

Conversation

maschino
Copy link
Member

@maschino maschino commented Dec 11, 2019

Summary

This PR migrates the react-ocean-forms-bootstrap repo to react-ocean-forms 3.0.0.

Checklist

Please ensure that you've fulfilled the following tasks:

  • My code follows the style guides of this project and yarn lint does not throw errors
  • My code is well tested and did not decrease the test coverage
  • All new and existing tests have passed
  • My submission passes the build
  • I've added changes to CHANGELOG.MD
  • I've updated the project documentation

@coveralls
Copy link

coveralls commented Jan 21, 2020

Pull Request Test Coverage Report for Build 858

  • 177 of 259 (68.34%) changed or added relevant lines in 25 files are covered.
  • 39 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-35.9%) to 64.103%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/components/Select/Select/Select.tsx 4 7 57.14%
src/components/DatePicker/PlaintextDatePicker/PlaintextDatePicker.tsx 4 19 21.05%
src/components/Select/CreatableSelect/CreatableSelect.tsx 4 19 21.05%
src/components/DatePicker/DatePicker.tsx 4 21 19.05%
src/components/Select/SelectBase/SelectBase.tsx 3 35 8.57%
Files with Coverage Reduction New Missed Lines %
src/components/Select/SelectBase/SelectBase.types.ts 1 20.0%
src/components/Select/CreatableSelect/CreatableSelect.tsx 5 14.29%
src/components/DatePicker/DatePicker.tsx 7 14.29%
src/components/Select/SelectBase/SelectBase.tsx 26 6.25%
Totals Coverage Status
Change from base Build 856: -35.9%
Covered Lines: 272
Relevant Lines: 393

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants