retry of 1 should retry once and run twice

envkey · Nov 7, 2018 · a47dfce · a47dfce
1 parent 514b93f
commit a47dfce
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/fetch/fetch.go b/fetch/fetch.go
@@ -90,7 +90,7 @@ func Fetch(envkey string, options FetchOptions) (string, error) {
 			fmt.Fprintln(os.Stderr, err)
 		}
 
-		if options.Retry > 1 {
+		if options.Retry > 0 {
 			options.Retry--
 			return Fetch(envkey, options)
 		}

diff --git a/fetch/fetch_test/fetch_test.go b/fetch/fetch_test/fetch_test.go
@@ -104,7 +104,7 @@ func TestFetch(t *testing.T) {
 
 			fetch.Fetch(test.envkey, opts)
 			if test.expectErr && test.responseStatus != http.StatusNotFound {
-				assert.Equal(retry, callCount, test.desc+" should retry")
+				assert.Equal(retry+1, callCount, test.desc+" should retry")
 			} else {
 				assert.Equal(1, callCount, test.desc+" should not retry")
 			}