Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no clue if conflicting module unload was attempted when raising conflict issue #261

Closed
xdelaruelle opened this issue Apr 21, 2019 · 0 comments
Assignees
Labels
Milestone

Comments

@xdelaruelle
Copy link
Collaborator

Taking following modules as example:

$ module show mb mc me mf
-------------------------------------------------------------------
/path/to/modulefiles/mb:

module          load mc
-------------------------------------------------------------------
/path/to/modulefiles/mc:

module          unload mc
-------------------------------------------------------------------
/path/to/modulefiles/me:

module          load mb
module          load mf
-------------------------------------------------------------------
/path/to/modulefiles/mf:

module          unload mc
-------------------------------------------------------------------

When loading me, its requirements express conflicting needs. mc is first loaded by mb then mf attempts to remove it. However failing automated unload of mc is not reported and a confusing message suggesting the unload should be done is returned:

$ module load me
Unloading mc
  ERROR: mc cannot be unloaded due to a prereq.
    HINT: Might try "module unload mb" first.

Loading mf
  ERROR: mf cannot be loaded due to a conflict.
    HINT: Might try "module unload mc" first.

Loading me
  ERROR: me cannot be loaded due to missing prereq.
    HINT: the following module must be loaded first: mf
@xdelaruelle xdelaruelle added this to the 4.2.4 milestone Apr 21, 2019
@xdelaruelle xdelaruelle self-assigned this Apr 21, 2019
xdelaruelle added a commit that referenced this issue Apr 21, 2019
When loading a module, report any loaded conflict on the message
reporting block corresponding to this module load. This warning or error
message comes in addition to the eventual conflict unload message
reported under the message block of the main evaluation.

When a module load is forced and a conflict of this module is loaded,
report this conflict with the same concise message (no hint) whether an
unload of this conflicting module was attempted or not.

Fixes #261.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant