Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix APT repository instructions to work #26

Merged
merged 2 commits into from
Nov 9, 2024
Merged

Conversation

slovdahl
Copy link
Contributor

@slovdahl slovdahl commented Nov 8, 2024

The instructions on https://www.envoyproxy.io/docs/envoy/v1.32.1/start/install#install-envoy-on-debian-based-linux are correct, but the instructions here did not work out of the box.

The instructions on https://www.envoyproxy.io/docs/envoy/v1.32.1/start/install#install-envoy-on-debian-based-linux are correct, but the instructions here did not work out of the box.

Signed-off-by: Sebastian Lövdahl <slovdahl@hibox.fi>
Copy link

netlify bot commented Nov 8, 2024

👷 Deploy request for envoy-apt pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 9078536

Copy link
Member

@phlax phlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for this @slovdahl

i forgot to update these instructions when i fixed the other

Signed-off-by: Sebastian Lövdahl <slovdahl@hibox.fi>
@slovdahl
Copy link
Contributor Author

slovdahl commented Nov 9, 2024

Removed a comma that shouldn't have been there.

@phlax phlax merged commit 91585df into envoyproxy:main Nov 9, 2024
1 check passed
@slovdahl slovdahl deleted the patch-1 branch November 10, 2024 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants