Skip to content

Commit

Permalink
Remove rules_cc uses
Browse files Browse the repository at this point in the history
Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
  • Loading branch information
keith committed Jul 13, 2022
1 parent 41369cc commit 83ea04d
Show file tree
Hide file tree
Showing 9 changed files with 2 additions and 12 deletions.
3 changes: 1 addition & 2 deletions bazel/android_artifacts.bzl
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
load("@build_bazel_rules_android//android:rules.bzl", "android_binary")
load("@envoy_mobile//bazel:dokka.bzl", "sources_javadocs")
load("@rules_java//java:defs.bzl", "java_binary")
load("@rules_cc//cc:defs.bzl", "cc_library")
load("@google_bazel_common//tools/maven:pom_file.bzl", "pom_file")

# This file is based on https://github.com/aj-michael/aar_with_jni which is
Expand Down Expand Up @@ -203,7 +202,7 @@ def _create_jni_library(name, native_deps = []):
# We wrap our native so dependencies in a cc_library because android_binaries
# require a library target as dependencies in order to generate the appropriate
# architectures in the directory `lib/`
cc_library(
native.cc_library(
name = cc_lib_name,
srcs = native_deps,
)
Expand Down
3 changes: 1 addition & 2 deletions bazel/apple_test.bzl
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
load("@build_bazel_rules_apple//apple:ios.bzl", "ios_unit_test")
load("@build_bazel_rules_swift//swift:swift.bzl", "swift_library")
load("@rules_cc//cc:defs.bzl", "objc_library")
load("//bazel:config.bzl", "MINIMUM_IOS_VERSION")

# Macro providing a way to easily/consistently define Swift unit test targets.
Expand Down Expand Up @@ -44,7 +43,7 @@ def envoy_mobile_swift_test(name, srcs, data = [], deps = [], tags = [], reposit

def envoy_mobile_objc_test(name, srcs, data = [], deps = [], tags = [], visibility = []):
test_lib_name = name + "_lib"
objc_library(
native.objc_library(
name = test_lib_name,
srcs = srcs,
data = data,
Expand Down
1 change: 0 additions & 1 deletion examples/objective-c/hello_world/BUILD
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
load("//bazel:config.bzl", "MINIMUM_IOS_VERSION")
load("@rules_cc//cc:defs.bzl", "objc_library")
load("@build_bazel_rules_apple//apple:ios.bzl", "ios_application")

licenses(["notice"]) # Apache 2
Expand Down
1 change: 0 additions & 1 deletion library/common/jni/BUILD
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
load("//bazel:kotlin_lib.bzl", "envoy_mobile_so_to_jni_lib")
load("//bazel:android_debug_info.bzl", "android_debug_info")
load("@rules_cc//cc:defs.bzl", "cc_binary", "cc_library")
load("@envoy//bazel:envoy_build_system.bzl", "envoy_package")
load("//bazel:envoy_mobile_test_extensions.bzl", "TEST_EXTENSIONS")

Expand Down
1 change: 0 additions & 1 deletion library/common/jni/import/BUILD
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
load("@rules_cc//cc:defs.bzl", "cc_library")
load("@envoy//bazel:envoy_build_system.bzl", "envoy_package")

licenses(["notice"]) # Apache 2
Expand Down
2 changes: 0 additions & 2 deletions library/objective-c/BUILD
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
load("@rules_cc//cc:defs.bzl", "objc_library")

licenses(["notice"]) # Apache 2

exports_files([
Expand Down
1 change: 0 additions & 1 deletion test/common/jni/BUILD
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
load("@envoy//bazel:envoy_build_system.bzl", "envoy_package")
load("@rules_cc//cc:defs.bzl", "cc_binary")
load("//bazel:kotlin_lib.bzl", "envoy_mobile_so_to_jni_lib")

licenses(["notice"]) # Apache 2
Expand Down
1 change: 0 additions & 1 deletion test/swift/integration/BUILD
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
load("@rules_cc//cc:defs.bzl", "objc_library")
load("@envoy_mobile//bazel:apple_test.bzl", "envoy_mobile_swift_test")
load("@envoy_mobile//bazel:envoy_mobile_test_extensions.bzl", "TEST_EXTENSIONS")
load("@envoy//bazel:envoy_build_system.bzl", "envoy_cc_library")
Expand Down
1 change: 0 additions & 1 deletion third_party/rbe_configs/cc/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@

load(":cc_toolchain_config.bzl", "cc_toolchain_config")
load(":armeabi_cc_toolchain_config.bzl", "armeabi_cc_toolchain_config")
load("@rules_cc//cc:defs.bzl", "cc_toolchain", "cc_toolchain_suite")

package(default_visibility = ["//visibility:public"])

Expand Down

0 comments on commit 83ea04d

Please sign in to comment.