assert: emit events for assertions #1703
Conversation
Augustyniak
force-pushed
the
emit-events-for-assertions
branch
4 times, most recently
from
d7c4cfa to
131b3ee
Compare
test/common/main_interface_test.cc
Outdated
| // Verify that no crash if the assertion fails when no real event | ||
| // tracker is passed at engine's initialization time. |
There was a problem hiding this comment.
Verify that we don't crash
What assertion is failing here?
There was a problem hiding this comment.
going to change the order of sentences in this comment but basically we are simulating a failed assertion by calling Assert::invokeDebugAssertionFailureRecordActionForAssertMacroUseOnly:
// Simulate a failed assertion by invoking a debug assertion failure
// record action.
library/common/main_interface.h
Outdated
| @@ -163,9 +163,11 @@ envoy_status_t register_platform_api(const char* name, void* api); | |||
| * Initialize an engine for handling network streams. | |||
| * @param callbacks, the callbacks that will run the engine callbacks. | |||
| * @param logger, optional callbacks to handle logging. | |||
| * @param event_tracker, optional event tracker for the emission of events. | |||
There was a problem hiding this comment.
(Asking because you're explicitly registering a null tracker in the cc path.)
There was a problem hiding this comment.
nah, it's not - used to be initially since it was a pointer but I changed it to be a struct so this no longer holds. Updating.
|
In principal I'm good with this. I have some nits that I've refrained from posting here - I'd be fine with merging and iterating. Depending on what you'd like to do though, I can post them and we could iterate here as well. |
Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com>
Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com>
Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com>
Augustyniak
force-pushed
the
emit-events-for-assertions
branch
from
32e4d0f to
c2ab3dc
Compare
Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com>
Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com>
Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com>
Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com>
Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com>
Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com>
Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com>
Augustyniak
force-pushed
the
emit-events-for-assertions
branch
from
c2ab3dc to
9ab360d
Compare
Description: Send an envoy event with the use of envoy event tracker every time an assertion is hit. The event contains two fields:
nameequal toassertionand location which contains the information about the name of the file and line number for where the assertion was hit.Risk Level: Low. Optional feature that's active only when
DENVOY_LOG_DEBUG_ASSERT_IN_RELEASEcompilation flag is specified.Testing: Unit/Integration
Docs Changes: N/A
Release Notes: N/A