Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI fix: Upgrade CI image to use clang 12 #1845

Merged
merged 4 commits into from
Sep 30, 2021
Merged

Conversation

lfpino
Copy link
Contributor

@lfpino lfpino commented Sep 29, 2021

Signed-off-by: Luis Fernando Pino Duque luis@engflow.com

Description:
envoyproxy/envoy#18220 updated run_bazel_coverage_script.sh to require clang 12 thus making the current coverage script to always fail due to https://github.com/envoyproxy/envoy/blob/0656e34e0c87a77fb87273be89afd4922a30c7db/test/run_envoy_bazel_coverage.sh#L5. This PR updates the Ubuntu CI images in the envoy-mobile repo to match the image in Envoy.

Risk Level: Low
Testing: See CI workflows
Docs Changes: N/A
Release Notes: N/A

…s caused by envoyproxy/envoy#18220 updating the run_bazel_coverage_script.sh

Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
@lfpino lfpino changed the title CI fix: Upgrade envoyproxy/envoy-build-ubuntu docker image which uses clang 12 CI fix: Upgrade CI image to use clang 12 Sep 29, 2021
@lfpino lfpino marked this pull request as ready for review September 29, 2021 10:16
Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
@keith keith merged commit 97d9d3b into envoyproxy:main Sep 30, 2021
@keith
Copy link
Member

keith commented Sep 30, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants