Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: patch nlohmann/json #1904

Merged
merged 8 commits into from
Dec 23, 2021
Merged

deps: patch nlohmann/json #1904

merged 8 commits into from
Dec 23, 2021

Conversation

junr03
Copy link
Member

@junr03 junr03 commented Nov 1, 2021

Description: creates a patch forn nlohmann/json to deal with incompatibilities in it's code with use of std::filesystem in iOS<13.
Risk Level: low - compile patch
Testing: build

Jose Nino added 8 commits November 1, 2021 12:15
Signed-off-by: Jose Nino <jnino@lyft.com>
Signed-off-by: Jose Nino <jnino@lyft.com>
Signed-off-by: Jose Nino <jnino@lyft.com>
Signed-off-by: Jose Nino <jnino@lyft.com>
…json-patch

Signed-off-by: Jose Nino <jnino@lyft.com>
Signed-off-by: Jose Nino <jnino@lyft.com>
Signed-off-by: Jose Nino <jnino@lyft.com>
Signed-off-by: Jose Nino <jnino@lyft.com>
@junr03 junr03 marked this pull request as ready for review December 23, 2021 22:09
@junr03 junr03 merged commit b81facc into main Dec 23, 2021
@junr03 junr03 deleted the json-patch branch December 23, 2021 22:28
@jpsim
Copy link
Contributor

jpsim commented Dec 30, 2021

We can remove this patch once nlohmann/json#3101 makes it into a release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants