Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix V6 interface binding logging #1959

Merged
merged 2 commits into from
Dec 2, 2021
Merged

Fix V6 interface binding logging #1959

merged 2 commits into from
Dec 2, 2021

Conversation

jpsim
Copy link
Contributor

@jpsim jpsim commented Dec 2, 2021

Description: Both v4_interfaces and v6_interfaces were using V4 interfaces likely due to a typo. This is a follow-up to #1897.
Risk Level: Low, just fixing a log.
Testing:
Docs Changes:
Release Notes:
[Optional Fixes #Issue]
[Optional Deprecated:]

@jpsim
Copy link
Contributor Author

jpsim commented Dec 2, 2021

FYI @goaway

Both `v4_interfaces` and `v6_interfaces` were using V4 interfaces.

Signed-off-by: JP Simard <jp@jpsim.com>
Signed-off-by: JP Simard <jp@jpsim.com>
@jpsim jpsim changed the title Fix V6 interface binding Fix V6 interface binding logging Dec 2, 2021
@junr03 junr03 merged commit 1e9b4b1 into envoyproxy:main Dec 2, 2021
@jpsim jpsim deleted the patch-1 branch December 2, 2021 22:21
junr03 pushed a commit that referenced this pull request Dec 15, 2021
Description: Both v4_interfaces and v6_interfaces were using V4 interfaces likely due to a typo. This is a follow-up to #1897.
Risk Level: Low, just fixing a log.

Signed-off-by: JP Simard <jp@jpsim.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants