[CI] Update Xcode to 13.2.1 #1997
Conversation
Release notes: https://developer.apple.com/documentation/xcode-release-notes/xcode-13_2_1-release-notes Signed-off-by: JP Simard <jp@jpsim.com>
|
@lfpino is there a documented process for updating EngFlow to install new Xcode versions on its remote execution workers? |
Until we can install Xcode 13.2.1 on the EngFlow remote executors. Signed-off-by: JP Simard <jp@jpsim.com>
Signed-off-by: JP Simard <jp@jpsim.com>
|
Thanks for your quick reply, Luis!
It's not urgent, but I was expecting to be able to handle the changes myself fairly quickly, so it came as a surprise that there's infrastructure that I can't configure that's involved here. In fact, by temporarily disabling EngFlow in the GitHub Actions scripts, everything works with Xcode 13.2.1 by executing jobs directly on the GitHub Actions agents. Of course, this takes much longer to compile so I'd like to wait for Xcode 13.2.1 support in EngFlow before merging this. I think whatever comes of this I'll want to document the process for updating Xcode versions so that moving forward we know what to expect, and can give you a proper heads up, etc. |
|
Yeah, that makes a lot of sense :-) I can file an internal feature request for us to track this. IIRC we just haven't had this use case before. And 100% agree that having good documentation on how to handle this is critical, so maybe we can add some instructions in the Envoy as part of the upgrade. WDYT? |
Yes, that'd be great. Ideally we'd have better documentation about how CI works overall, for both Envoy and Envoy Mobile. Maybe we can collaborate to write that up? Based on my understanding, which likely is incorrect in some ways:
Am I getting that right? |
I don't mean to rush you with this question, I'm just trying to understand: how much lead time should we expect to request a new Xcode version on EngFlow executors? Are we talking on the order of days, weeks or months? |
|
I'm super familiar on how Envoy mobile CI works but not so much about Envoy. I can definitely help writing something :-) I believe the three points you mention are mostly correct, except that for Envoy Mobile we use Engflow and the GH runner doesn't necessarily need to match the Engflow worker configuration but we do use the same docker image for both (i.e. running the CI job and running the actual Bazel actions). W.r.t timing, once Apple has made XCode available it's usually a matter of days (even hours) to upgrade, so I'd say that asking us ~1-2 weeks in advance is enough. We also have an oncall that can take care of this quicker for urgent situations. So it's just a matter of asking and it may not even be worth automating this fully since there's only a few versions per year, but we can always discuss it. |
|
Ok thanks for sharing. We’d like to request support for Xcode 13.2.1 in EngFlow whenever possible, and we’ll merge this as soon as that’s available. There’s no big rush but we’re ready when you are. |
|
It's unfortunately not super straight forward to upgrade Xcode on our side. Bazel only sends the Xcode version to RE, so we need to have Xcode installed on the executors (because Apple's license says so). The way we do that today is by installing Xcode when building our release images, which means that we need to cut a release to update Xcode. Additionally, Xcode needs a lot of space on the images, so we can only fit a certain number of versions into the image. Plus, we need to coordinate changes there between everyone using the image which takes time. I have something on my todo list to improve the situation and at least allow us to install more than 2-3 Xcode versions at a time in an image, but there's a lot of other things on my todo list as well. We'll start the process of adding Xcode 13.2.1 to our images now, but it'll probably be next week until it's rolled out TBH. |
|
If I'm understanding you correctly, you can only have a single macOS image rolled out at any given time across all your customers? Thanks for kicking off the process. Please keep us posted of your progress. |
|
Hey @jpsim, Yannic has been making some changes to our images to add the new XCode, should be ready in the next few days :) |
|
ok thanks for the update! |
|
You should be able to try now, we rolled out new images that contain the new XCode. Let us know if you see any problems. |
* origin/main: (21 commits) owners: adding charles (envoyproxy#2038) [OWNERS] Update Envoy Mobile owners (envoyproxy#2031) [deps] Update rules_android to a stable release URL (envoyproxy#2032) [json] Remove com_github_nlohmann_json override & patch (envoyproxy#2030) Enable the "received byte count" feature. (envoyproxy#2004) Run Kotlin macOS tests without EngFlow (envoyproxy#2018) final_intel: adding response flags (envoyproxy#2009) fix (envoyproxy#2025) stream intel: update kotlin public interface to align with swift (envoyproxy#2013) tls: update bundled root certificates (envoyproxy#2016) tooling: first pass at oncall tooling (envoyproxy#2014) test: Solve CI flakiness for test/java/org/chromium/net/urlconnection:urlconnection_test (envoyproxy#2007) envoy: 519774f742 (envoyproxy#2015) Default timestamp to -1 for envoy_final_stream_intel (envoyproxy#2006) QuicTestServer (envoyproxy#1989) bump boringssl to Envoy's version (envoyproxy#1999) docs: addding release notes (envoyproxy#2001) release: cutting the 0.4.5 release (envoyproxy#2000) Revert "bazel: change bazelisk for M1 support (envoyproxy#1966)" (envoyproxy#1998) Decompress even when `no-transform` is specified (envoyproxy#1995) ... Signed-off-by: JP Simard <jp@jpsim.com>
…nfig" This reverts commit f6d0d01. Signed-off-by: JP Simard <jp@jpsim.com>
This reverts commit d47f3a0. Signed-off-by: JP Simard <jp@jpsim.com>
* main: timing test (envoyproxy#2035) [CI] Update Xcode to 13.2.1 (envoyproxy#1997) owners: adding charles (envoyproxy#2038) [OWNERS] Update Envoy Mobile owners (envoyproxy#2031) [deps] Update rules_android to a stable release URL (envoyproxy#2032) Signed-off-by: JP Simard <jp@jpsim.com>
* main: envoy: 71248e512 (envoyproxy#2027) Migrate EngFlow configurations from rbe_autoconfig to rbe_configs_gen (envoyproxy#2037) timing test (envoyproxy#2035) [CI] Update Xcode to 13.2.1 (envoyproxy#1997) owners: adding charles (envoyproxy#2038) Signed-off-by: JP Simard <jp@jpsim.com>
Release notes: https://developer.apple.com/documentation/xcode-release-notes/xcode-13_2_1-release-notes
Description: Update the Xcode version used in build configuration files to use the latest stable Xcode release: Xcode 13.2.1.
Risk Level: Medium, this updates the versions of llvm, clang, swift as well as the Apple frameworks we link against.
Testing: Existing tests
Docs Changes: Updated.
Release Notes:
[Optional Fixes #Issue]
[Optional Deprecated:]