Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

android: update bazel flag config #684

Merged
merged 5 commits into from
Feb 13, 2020
Merged

android: update bazel flag config #684

merged 5 commits into from
Feb 13, 2020

Conversation

junr03
Copy link
Member

@junr03 junr03 commented Feb 11, 2020

Description: envoyproxy/envoy#9767 introduced the bazel option and #663 brought it into envoy mobile. This PR changes the bazel config for android to turn on the logger by default when building on android. It also updates a couple other stale flags and docs.
Risk Level: low
Testing: tested locally and saw logs

Fixes #34

Signed-off-by: Jose Nino jnino@lyft.com

Signed-off-by: Jose Nino <jnino@lyft.com>
@junr03 junr03 requested a review from buildbreaker February 11, 2020 23:40
buildbreaker
buildbreaker previously approved these changes Feb 12, 2020
Signed-off-by: Jose Nino <jnino@lyft.com>
@junr03 junr03 changed the title android: turn on android logger android: update bazel flag config Feb 12, 2020
Signed-off-by: Jose Nino <jnino@lyft.com>
@junr03
Copy link
Member Author

junr03 commented Feb 12, 2020

@buildbreaker I actually noticed a couple more places to clean up. lmk what you think

.bazelrc Outdated Show resolved Hide resolved
Signed-off-by: Jose Nino <jnino@lyft.com>
buildbreaker
buildbreaker previously approved these changes Feb 12, 2020
Signed-off-by: Jose Nino <jnino@lyft.com>
@junr03 junr03 merged commit 98ea37c into master Feb 13, 2020
@junr03 junr03 deleted the android-logger branch February 13, 2020 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

logging sink for Android
3 participants