This repository has been archived by the owner on Dec 16, 2020. It is now read-only.
Upgrade to cel-cpp v0.2.0 to pick up ANTLR thread-safety changes. #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tristan Swadell <tswadell@google.com>
Signed-off-by: Tristan Swadell <tswadell@google.com>
Signed-off-by: Tristan Swadell <tswadell@google.com>
TristonianJones
requested review from
jplevyak,
lizan and
PiotrSikora
as code owners
jplevyak
approved these changes
May 12, 2020
|
@jplevyak we need to cherry-pick this into istio/envoy-1.6 and should make its way to istio-proxy:1.6.1 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tristan Swadell tswadell@google.com
For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Description: The CEL module used by Envoy-WASM is not thread-safe. A recent upgrade within the https://github.com/google/cel-cpp repo upgraded the C++ ANTLR runtime from v4.7.1 to v4.7.2 with a repro case to verify the thread-unsafe before behavior and the thread-safe after behavior. There may be additional issues above CEL within the Envoy-WASM stack which caused the segfault in #497; however, the change should remove a number of possible bugs and narrow the scope of the segfault search.
Risk Level: Low
Testing: Unit testing in the cel-cpp stack.
Docs Changes: n/a
Release Notes: CEL thread-safety improvements
[Optional Fixes #Issue]
[Optional Deprecated:]