comment

envoyproxy · Mar 27, 2017 · 2176c06 · 2176c06
1 parent f30581e
commit 2176c06
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/source/common/redis/command_splitter_impl.cc b/source/common/redis/command_splitter_impl.cc
@@ -157,7 +157,8 @@ SplitRequestPtr InstanceImpl::makeRequest(const RespValue& request, SplitCallbac
 
   auto handler = command_map_.find(request.asArray()[0].asString());
   if (handler == command_map_.end()) {
-    callbacks.onResponse(Utility::makeError("unsupported command"));
+    callbacks.onResponse(Utility::makeError(
+        fmt::format("unsupported command '{}'", request.asArray()[0].asString())));
     return nullptr;
   }
 

diff --git a/test/common/redis/command_splitter_impl_test.cc b/test/common/redis/command_splitter_impl_test.cc
@@ -67,7 +67,7 @@ TEST_F(RedisCommandSplitterImplTest, InvalidRequestArrayNotStrings) {
 TEST_F(RedisCommandSplitterImplTest, UnsupportedCommand) {
   RespValue response;
   response.type(RespType::Error);
-  response.asString() = "unsupported command";
+  response.asString() = "unsupported command 'newcommand'";
   EXPECT_CALL(callbacks_, onResponse_(PointeesEq(&response)));
   RespValue request;
   makeBulkStringArray(request, {"newcommand", "hello"});