addressing comments N4

* removed ASSERT from localPort helper
* added ref into prot description
* added ref to release notes
* rebase

Signed-off-by: Nikita V. Shirokov <tehnerd@tehnerd.com>

api/envoy/config/filter/network/http_connection_manager/v2/http_connection_manager.proto

@@ -32,7 +32,7 @@ option (udpa.annotations.file_status).package_version_status = FROZEN;
 // HTTP connection manager :ref:`configuration overview <config_http_conn_man>`.
 // [#extension: envoy.filters.network.http_connection_manager]
 
-// [#next-free-field: 37]
+// [#next-free-field: 39]
 message HttpConnectionManager {
   enum CodecType {
     // For every new connection, the connection manager will determine which
@@ -513,10 +513,10 @@ message HttpConnectionManager {
   RequestIDExtension request_id_extension = 36;
 
   // Determines if the port part should be removed from host/authority header before any processing
-  // of request by HTTP filters or routing. The port would be removed only if it is equal to the listener's
+  // of request by HTTP filters or routing. The port would be removed only if it is equal to the :ref:`listener's<config.listener.v3.Listener>`
   // local port and request method is not CONNECT. This affects the upstream host header as well.
   // Without setting this option, incoming requests with host `example:443` will not match against
-  // route with `domains` match set to `example`. Defaults to `false`. Note that port removal is not part
+  // route with :ref:`domains<config.route.v3.VirtualHost>` match set to `example`. Defaults to `false`. Note that port removal is not part
   // of `HTTP spec <https://tools.ietf.org/html/rfc3986>` and is provided for convenience.
   bool strip_matching_host_port = 38;
 }

api/envoy/extensions/filters/network/http_connection_manager/v3/http_connection_manager.proto

@@ -508,10 +508,10 @@ message HttpConnectionManager {
   RequestIDExtension request_id_extension = 36;
 
   // Determines if the port part should be removed from host/authority header before any processing
-  // of request by HTTP filters or routing. The port would be removed only if it is equal to the listener's
+  // of request by HTTP filters or routing. The port would be removed only if it is equal to the :ref:`listener's<config.listener.v3.Listener>`
   // local port and request method is not CONNECT. This affects the upstream host header as well.
   // Without setting this option, incoming requests with host `example:443` will not match against
-  // route with `domains` match set to `example`. Defaults to `false`. Note that port removal is not part
+  // route with :ref:`domains<config.route.v3.VirtualHost>` match set to `example`. Defaults to `false`. Note that port removal is not part
   // of `HTTP spec <https://tools.ietf.org/html/rfc3986>` and is provided for convenience.
   bool strip_matching_host_port = 38;
 }

api/envoy/extensions/filters/network/http_connection_manager/v4alpha/http_connection_manager.proto

@@ -508,10 +508,10 @@ message HttpConnectionManager {
   RequestIDExtension request_id_extension = 36;
 
   // Determines if the port part should be removed from host/authority header before any processing
-  // of request by HTTP filters or routing. The port would be removed only if it is equal to the listener's
+  // of request by HTTP filters or routing. The port would be removed only if it is equal to the :ref:`listener's<config.listener.v3.Listener>`
   // local port and request method is not CONNECT. This affects the upstream host header as well.
   // Without setting this option, incoming requests with host `example:443` will not match against
-  // route with `domains` match set to `example`. Defaults to `false`. Note that port removal is not part
+  // route with :ref:`domains<config.route.v3.VirtualHost>` match set to `example`. Defaults to `false`. Note that port removal is not part
   // of `HTTP spec <https://tools.ietf.org/html/rfc3986>` and is provided for convenience.
   bool strip_matching_host_port = 38;
 }

docs/root/version_history/current.rst

@@ -24,6 +24,7 @@ Changes
   Can be reverted temporarily by setting runtime feature `envoy.reloadable_features.fix_upgrade_response` to false.
 * http: remove legacy connection pool code and their runtime features: `envoy.reloadable_features.new_http1_connection_pool_behavior` and
   `envoy.reloadable_features.new_http2_connection_pool_behavior`.
+* http connection manager: added :ref:`stripping port from host header <envoy_v3_api_field_extensions.filters.network.http_connection_manager.v3.HttpConnectionManager>` support.
 * listener: added in place filter chain update flow for tcp listener update which doesn't close connections if the corresponding network filter chain is equivalent during the listener update.
   Can be disabled by setting runtime feature `envoy.reloadable_features.listener_in_place_filterchain_update` to false.
   Also added additional draining filter chain stat for :ref:`listener manager <config_listener_manager_stats>` to track the number of draining filter chains and the number of in place update attempts.