Skip to content

Commit

Permalink
dependencies: fix release_dates error behavior. (#14216)
Browse files Browse the repository at this point in the history
Previously was exiting 0, so failures still passed CI.

Signed-off-by: Harvey Tuch <htuch@google.com>
  • Loading branch information
htuch authored Nov 30, 2020
1 parent 2aee439 commit 468d7c9
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
6 changes: 3 additions & 3 deletions bazel/repository_locations.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ REPOSITORY_LOCATIONS_SPEC = dict(
strip_prefix = "c-ares-{version}",
urls = ["https://github.com/c-ares/c-ares/releases/download/cares-{underscore_version}/c-ares-{version}.tar.gz"],
use_category = ["dataplane_core", "controlplane"],
release_date = "2020-10-21",
release_date = "2020-11-19",
cpe = "cpe:2.3:a:c-ares_project:c-ares:*",
),
com_github_circonus_labs_libcircllhist = dict(
Expand Down Expand Up @@ -414,7 +414,7 @@ REPOSITORY_LOCATIONS_SPEC = dict(
urls = ["https://github.com/google/jwt_verify_lib/archive/{version}.tar.gz"],
use_category = ["dataplane_ext"],
extensions = ["envoy.filters.http.jwt_authn"],
release_date = "2020-11-04",
release_date = "2020-11-05",
cpe = "N/A",
),
com_github_nodejs_http_parser = dict(
Expand Down Expand Up @@ -513,7 +513,7 @@ REPOSITORY_LOCATIONS_SPEC = dict(
urls = ["https://github.com/grpc-ecosystem/grpc-httpjson-transcoding/archive/{version}.tar.gz"],
use_category = ["dataplane_ext"],
extensions = ["envoy.filters.http.grpc_json_transcoder"],
release_date = "2020-11-12",
release_date = "2020-11-13",
cpe = "N/A",
),
io_bazel_rules_go = dict(
Expand Down
1 change: 1 addition & 0 deletions tools/dependency/release_dates.py
Original file line number Diff line number Diff line change
Expand Up @@ -105,3 +105,4 @@ def VerifyAndPrintReleaseDates(repository_locations, github_instance):
except ReleaseDateError as e:
print(f'An error occurred while processing {path}, please verify the correctness of the '
f'metadata: {e}')
sys.exit(1)

0 comments on commit 468d7c9

Please sign in to comment.