SIPProxy BUGFIX UT failure for fastbuild/debug (#18303)

Signed-off-by: Felix Du <durd07@gmail.com>
envoyproxy · Sep 29, 2021 · 46bcf76 · 46bcf76
1 parent 536de8d
commit 46bcf76
Showing 1 changed file with 2 additions and 8 deletions.
diff --git a/contrib/sip_proxy/filters/network/test/conn_manager_test.cc b/contrib/sip_proxy/filters/network/test/conn_manager_test.cc
@@ -247,13 +247,6 @@ stat_prefix: egress
       filter_->stats_.response_exception_.inc();
       EXPECT_EQ(2U, filter_->stats_.response_exception_.value());
     }
-    /*
-        // metadata = nullptr
-        std::string transid = trans->transactionId();
-        trans->metadata_ = nullptr;
-        filter_->transactions_.emplace(transid, std::move(trans));
-        filter_->transactions_.at(transid)->upstreamData(filter_->decoder_->metadata_);
-    */
 
     // transportEnd throw envoyException
     filter_->read_callbacks_->connection().setDelayedCloseTimeout(std::chrono::milliseconds(1));
@@ -263,7 +256,8 @@ stat_prefix: egress
     try {
       ConnectionManager::ResponseDecoder response_decoder(*trans1);
       response_decoder.newDecoderEventHandler(filter_->decoder_->metadata());
-      response_decoder.transportEnd();
+      // transportEnd throw envoyException
+      response_decoder.onData(filter_->decoder_->metadata());
     } catch (const EnvoyException& ex) {
       filter_->stats_.response_exception_.inc();
       EXPECT_EQ(2U, filter_->stats_.response_exception_.value());