Skip to content

Commit

Permalink
core: comment on setup_envoy/run_engine ordering (#345)
Browse files Browse the repository at this point in the history
Description: comment describing current ordering between setup_envoy and run_engine in the main_interface.
Risk Level: low - code comment

Signed-off-by: Jose Nino <jnino@lyft.com>
Signed-off-by: JP Simard <jp@jpsim.com>
  • Loading branch information
junr03 authored and jpsim committed Nov 29, 2022
1 parent 717f640 commit b9ac579
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions mobile/library/common/main_interface.cc
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,10 @@ envoy_engine_t init_engine() {

/*
* Setup envoy for interaction via the main interface.
* As it stands this function __must__ be executed after calling `run_engine`.
* run_engine assigns a static unique pointer used by this function.
* TODO: this will change when the engine is no longer static:
* https://github.com/lyft/envoy-mobile/issues/332
*/
void setup_envoy() {
http_dispatcher_ = std::make_unique<Envoy::Http::Dispatcher>(
Expand Down

0 comments on commit b9ac579

Please sign in to comment.