-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hardcoded v2 type urls in xds requests #10209
Labels
Comments
mattklein123
added
api/v3
Major version release @ end of Q3 2019
bug
help wanted
Needs help!
labels
Feb 28, 2020
cc @lizan |
htuch
pushed a commit
that referenced
this issue
Apr 3, 2020
#10209. There are hardcoded type URLs in resources.h. In this PR, I removed all of the dependencies of those. Now, codes that depend on that are only test code. In the future, I will remove that from test codes and completely destroy that. Risk Level: Low Testing: N/A Signed-off-by: shikugawa <rei@tetrate.io>
This was referenced Apr 15, 2020
htuch
pushed a commit
that referenced
this issue
Apr 22, 2020
penguingao
pushed a commit
to penguingao/envoy
that referenced
this issue
Apr 22, 2020
To resolve envoyproxy#10209. This is the continuation of envoyproxy#10479. Remove all of hard-coded type URLs, and operate subscriptions that have the same resource name. Risk Level: Low Signed-off-by: shikugawa <rei@tetrate.io> Signed-off-by: pengg <pengg@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Title: hardcoded v2 type urls in xds requests
Description:
In order to migrate to v3 API,
loadTypeUrl
functions are used to determine type url in discovery requests. However, I found that some files are still using v2 type url constants in this file. This means that even envoy is configured to use v3, it will still send requests for v2 resources.Correct me if there is any magic actually doing the conversion somewhere.
[optional Relevant Links:]
envoy/source/common/router/scoped_rds.cc
Line 243 in 334724c
envoy/source/common/router/scoped_rds.cc
Line 258 in 334724c
envoy/source/common/upstream/cds_api_impl.cc
Lines 68 to 70 in 334724c
envoy/source/common/upstream/cluster_manager_impl.cc
Lines 150 to 155 in 334724c
envoy/source/common/upstream/cluster_manager_impl.cc
Lines 752 to 754 in 334724c
envoy/source/server/lds_api.cc
Lines 43 to 45 in 334724c
envoy/source/server/server.cc
Lines 526 to 535 in 334724c
The text was updated successfully, but these errors were encountered: