Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support configurable date formats for DOWNSTREAM_PEER_CERT_V_START/END #14501

Closed
esmet opened this issue Dec 22, 2020 · 2 comments · Fixed by #14502 or #14830
Closed

Support configurable date formats for DOWNSTREAM_PEER_CERT_V_START/END #14501

esmet opened this issue Dec 22, 2020 · 2 comments · Fixed by #14502 or #14830
Assignees
@esmet
Labels
area/access_log

Comments

@esmet
Copy link
Contributor

esmet commented Dec 22, 2020

We currently support configurable date formats using an access log command operator for START_TIME but it would be helpful to expend this behavior to DOWNSTREAM_PEER_CERT_V_START and DOWNSTREAM_PEER_CERT_V_END as well.
@esmet esmet added enhancement Feature requests. Not bugs or questions. triage Issue requires triage labels Dec 22, 2020
@esmet esmet mentioned this issue Dec 22, 2020
Merged
@esmet
Copy link
Contributor Author

esmet commented Dec 22, 2020

/assign

@rgs1
Copy link
Member

rgs1 commented Dec 23, 2020

FWIW we are adding support for formatter extensions here:

#14512

So maybe this can be implemented as an extension.

@mattklein123 mattklein123 added area/access_log and removed enhancement Feature requests. Not bugs or questions. triage Issue requires triage labels Dec 26, 2020
@esmet esmet mentioned this issue Jan 26, 2021
Merged
zuercher pushed a commit that referenced this issue Feb 11, 2021
@esmet
router: support downstream cert formatting in the header formatter (#…
ceddde2 
…14830)

This extends downstream cert formatting capabilities to the router's header formatter.

Risk Level: Low
Testing: Unit tests
Docs Changes: Updated custom request/response header docs
Release Notes: added
Fixes #14501
esmet added a commit to datawire/envoy that referenced this issue Mar 29, 2021
@esmet
router: support downstream cert formatting in the header formatter (e…
1ad814c 
…nvoyproxy#14830)

This extends downstream cert formatting capabilities to the router's header formatter.

Risk Level: Low
Testing: Unit tests
Docs Changes: Updated custom request/response header docs
Release Notes: added
Fixes envoyproxy#14501
esmet added a commit to datawire/envoy that referenced this issue Apr 16, 2021
@esmet
router: support downstream cert formatting in the header formatter (e…
65939fa 
…nvoyproxy#14830)

This extends downstream cert formatting capabilities to the router's header formatter.

Risk Level: Low
Testing: Unit tests
Docs Changes: Updated custom request/response header docs
Release Notes: added
Fixes envoyproxy#14501
esmet added a commit to datawire/envoy that referenced this issue Jun 10, 2021
@esmet
router: support downstream cert formatting in the header formatter (e…
730aadf 
…nvoyproxy#14830)

This extends downstream cert formatting capabilities to the router's header formatter.

Risk Level: Low
Testing: Unit tests
Docs Changes: Updated custom request/response header docs
Release Notes: added
Fixes envoyproxy#14501
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@esmet esmet

Labels
area/access_log
Projects
None yet
Milestone
No milestone
3 participants
@rgs1 @esmet @mattklein123