Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gzip HTTP filter #269

Closed
fabware opened this issue Dec 3, 2016 · 10 comments
Closed

gzip HTTP filter #269

fabware opened this issue Dec 3, 2016 · 10 comments
Assignees
@gsagula
Labels
enhancement Feature requests. Not bugs or questions.
Milestone
1.6.0

Comments

@fabware
Copy link

fabware commented Dec 3, 2016

I use envoy as front end proxy, set Accept-Encoding: gzip doesn't work. Content doesn't get compressed.

There seems no document for encoding configuration.
@mattklein123 mattklein123 added the enhancement Feature requests. Not bugs or questions. label Dec 3, 2016
@mattklein123
Copy link
Member

Envoy is not a origin server and currently does not support any kind of automatic content transformation.

We could implement an HTTP compression filter so that is the feature request here.

@mattklein123 mattklein123 changed the title support gzip gzip HTTP filter Dec 3, 2016
@fabware
Copy link
Author

fabware commented Dec 4, 2016

Noted. Thanks for your clarification.

@gabriel-sagula-hs
Copy link

Hi @mattklein123, would be possible to see some http filter example?

@mattklein123
Copy link
Member

@gabriel-sagula-hs there are numerous examples in the existing code base. Can you look at one of those? I would love to have a more self contained example but don't have the time right now. (FWIW many people have written filters with little/no interaction with me so I know it's doable).

@gabriel-sagula-hs
Copy link

Thanks for the quick response @mattklein123
We are evaluating few products right now, including Envoy. One thing that is critical for us is to be able to accept gzip. So, I'm trying to write a filter for that.
Are those the examples that you refer to? https://github.com/lyft/envoy/tree/master/source/common/http/filter

Thanks!

@mattklein123
Copy link
Member

https://github.com/lyft/envoy/tree/master/source/server/config/http

@mattklein123
Copy link
Member

Also here: https://github.com/lyft/envoy/tree/master/source/server/http

Those are the config loaders for all the filters, which you can then search through to the code.

@gabriel-sagula-hs
Copy link

Thanks Matt for your time. This is very helpful.

@mattklein123 mattklein123 added the help wanted Needs help! label Jul 12, 2017
@mattklein123
Copy link
Member

This is being worked on by @gsagula

@mattklein123 mattklein123 modified the milestone: 1.5.0 Aug 10, 2017
@mattklein123 mattklein123 removed this from the 1.5.0 milestone Oct 6, 2017
@gsagula gsagula mentioned this issue Nov 21, 2017
Merged
@mattklein123 mattklein123 removed the help wanted Needs help! label Nov 22, 2017
@mattklein123 mattklein123 added this to the 1.6.0 milestone Nov 22, 2017
@gsagula gsagula mentioned this issue Dec 11, 2017
Merged
@mattklein123
Copy link
Member

Fixed

@rosskukulinski rosskukulinski mentioned this issue Aug 9, 2018
Closed
PiotrSikora referenced this issue in istio/envoy Nov 1, 2019
@PiotrSikora
Regenerate everything with Emscripten v1.39.0. (#269)
1621a6c 
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
jpsim pushed a commit that referenced this issue Nov 28, 2022
@rebello95 @jpsim
swift: add tests for request builders (#269)
5fba41f 
Adds tests for the request builders similar to the ones available on master for Kotlin.

Also fixes the `Equatable` comparison of `Request` by overriding `isEqual`. This is required since this type subclasses `NSObject` to be visible to Objective-C, and we want property comparison instead of pointer comparison here.

Resolves envoyproxy/envoy-mobile#252

Signed-off-by: Michael Rebello <mrebello@lyft.com>
Signed-off-by: JP Simard <jp@jpsim.com>
jpsim pushed a commit that referenced this issue Nov 29, 2022
@rebello95 @jpsim
swift: add tests for request builders (#269)
97bc3c2 
Adds tests for the request builders similar to the ones available on master for Kotlin.

Also fixes the `Equatable` comparison of `Request` by overriding `isEqual`. This is required since this type subclasses `NSObject` to be visible to Objective-C, and we want property comparison instead of pointer comparison here.

Resolves envoyproxy/envoy-mobile#252

Signed-off-by: Michael Rebello <mrebello@lyft.com>
Signed-off-by: JP Simard <jp@jpsim.com>
krinkinmu pushed a commit to krinkinmu/envoy that referenced this issue Nov 1, 2024
@tedjpoole
Merge pull request envoyproxy#269 from tedjpoole/scheduled-sync-from-…
38d920e 
…upstream

Stop envoy-sync-scheduled workflow running on forks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gsagula gsagula

Labels
enhancement Feature requests. Not bugs or questions.
Projects
None yet
Milestone
1.6.0
Development

No branches or pull requests
4 participants
@fabware @gsagula @mattklein123 @gabriel-sagula-hs