Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement "b3 single" header format #4289

Closed
codefromthecrypt opened this issue Aug 29, 2018 · 5 comments
Closed

implement "b3 single" header format #4289

codefromthecrypt opened this issue Aug 29, 2018 · 5 comments
Assignees
Labels
enhancement Feature requests. Not bugs or questions. help wanted Needs help!
Milestone

Comments

@codefromthecrypt
Copy link
Contributor

Title: implement "b3 single" header format

Description:
We should permit at least parsing the more compressed "b3" header format, if not making it possible to propagate it downstream.

ex. b3: 4bf92f3577b34da6a3ce929d0e0e4736-00f067aa0ba902b7-1

This is the same format as will be used in the w3c tracestate

Details are here: openzipkin/b3-propagation#21
Example implementation is here: https://github.com/openzipkin/brave/blob/master/brave/src/main/java/brave/propagation/B3SingleFormat.java https://github.com/openzipkin/brave/blob/master/brave/src/test/java/brave/propagation/B3SingleFormatTest.java

@lizan lizan added enhancement Feature requests. Not bugs or questions. help wanted Needs help! labels Aug 30, 2018
@zyfjeff
Copy link
Member

zyfjeff commented Sep 18, 2018

Is this issue still open and no one is working? If yes then i can start this one

@htuch
Copy link
Member

htuch commented Sep 18, 2018

@zyfjeff I've sent you an invite to join Envoy org, I can assign the issue to you when you accept.

@zyfjeff
Copy link
Member

zyfjeff commented Sep 27, 2018

@adriancole Need to make it configurable, or automatic identification using "b3 single" header format or b3, if is the automatic identification, then b3 single header and b3 which higher priority?

@codefromthecrypt
Copy link
Contributor Author

codefromthecrypt commented Sep 27, 2018 via email

@zyfjeff
Copy link
Member

zyfjeff commented Sep 27, 2018

@htuch please assign to me, i will take some time to implement the recently

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature requests. Not bugs or questions. help wanted Needs help!
Projects
None yet
Development

No branches or pull requests

5 participants