Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add local address IP version as CLI option #979

Closed
hennna opened this issue May 17, 2017 · 1 comment
Closed

Add local address IP version as CLI option #979

hennna opened this issue May 17, 2017 · 1 comment
Labels
enhancement Feature requests. Not bugs or questions.
Milestone
1.4.0

Comments

@hennna
Copy link
Contributor

hennna commented May 17, 2017

Thoughts on whether this can be used for both:

  1. Initializing LocalInfo (https://github.com/lyft/envoy/blob/master/source/exe/main.cc#L67) and
  2. UdpStatsdSink local address
    https://github.com/lyft/envoy/blob/master/source/common/stats/statsd.cc#L23

Or should the UdpStatsdSink local address version be a separate json field?
@mattklein123 mattklein123 added the enhancement Feature requests. Not bugs or questions. label May 17, 2017
@mattklein123
Copy link
Member

For (1), I agree we should add a CLI option that can optionally populate LocalInfo.

For (2), this is related to #948. This is not going to make the 1.3.0 config freeze, but we could deprecate the local UDP port field and add a local UDP address field instead which would fix both your issue as well as the other issue.

@htuch htuch mentioned this issue May 24, 2017
Closed
@hennna hennna mentioned this issue May 25, 2017
Merged
@hennna hennna mentioned this issue Jun 6, 2017
Merged
@mattklein123 mattklein123 modified the milestone: 1.4.0 Jun 7, 2017
rshriram pushed a commit to rshriram/envoy that referenced this issue Oct 30, 2018
@istio-testing
Update_Dependencies (envoyproxy#979)
151ea75 
Automatic merge from submit-queue.

[DO NOT MERGE] Auto PR to update dependencies of proxy

This PR will be merged automatically once checks are successful.
```release-note
none
```
jpsim pushed a commit that referenced this issue Nov 28, 2022
@goaway @jpsim
filters: rework callbacks for shared signatures (#979)
f401647 
Description: Rework callback signatures by allowing a type-erased return context similar to the context parameter that gets included in the call argument. This opens the door to filter callbacks and stream callbacks sharing streamlined bridge code, especially in the case of the JNI. Also improves upon the current header passing mechanism for the JNI.
Risk Level: Moderate
Testing: Local and CI

Signed-off-by: Mike Schore <mike.schore@gmail.com>
Signed-off-by: JP Simard <jp@jpsim.com>
jpsim pushed a commit that referenced this issue Nov 29, 2022
@goaway @jpsim
filters: rework callbacks for shared signatures (#979)
be9737c 
Description: Rework callback signatures by allowing a type-erased return context similar to the context parameter that gets included in the call argument. This opens the door to filter callbacks and stream callbacks sharing streamlined bridge code, especially in the case of the JNI. Also improves upon the current header passing mechanism for the JNI.
Risk Level: Moderate
Testing: Local and CI

Signed-off-by: Mike Schore <mike.schore@gmail.com>
Signed-off-by: JP Simard <jp@jpsim.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Feature requests. Not bugs or questions.
Projects
None yet
Milestone
1.4.0
Development

No branches or pull requests
2 participants
@mattklein123 @hennna