Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compressor: expose generic compressor filter to users #10553

Merged
merged 65 commits into from
May 8, 2020
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
65 commits
Select commit Hold shift + click to select a range
47139ba
compressor: expose generic compressor filter to users
Mar 19, 2020
4bc9660
fix naming conflict in compressor_filter_integration_test.cc
Mar 27, 2020
b7cfac0
fix clang-tidy findings
Mar 27, 2020
fd7fab2
coverage: fix naming conflict
Mar 30, 2020
7bfd623
fix bazel compile_time_options build
Mar 30, 2020
153f97e
Merge remote-tracking branch 'upstream/master' into compress
Mar 31, 2020
09f10a9
explicitly deprecate gzip filter
Mar 31, 2020
d9b33cc
fix bazel compile_time_options build
Apr 1, 2020
90d02d5
address review comments
Apr 6, 2020
05a8541
zlib: use Z_DEFAULT_STRATEGY by default instead of Z_FIXED
Apr 7, 2020
c3c26b6
gzip.proto: rework CompressionStrategy and CompressionLevel enums
Apr 7, 2020
ece1755
compressor: make compressor_library required
Apr 7, 2020
3323683
gzip: allow setting of chunk size
Apr 7, 2020
b7e1d28
document the Fixed compression strategy
Apr 8, 2020
85676a2
Merge remote-tracking branch 'upstream/master' into compress
Apr 9, 2020
681d7c4
move to v3 proto
Apr 8, 2020
79051a7
Merge remote-tracking branch 'upstream/master' into compress
Apr 14, 2020
9bcc469
update version history
Apr 14, 2020
21fb4eb
fix pedantic spelling check
Apr 14, 2020
2f48548
make use of PROTOBUF_GET_WRAPPED_OR_DEFAULT
Apr 14, 2020
63085ac
compressor: introduce CompressorPtr type alias
Apr 14, 2020
edbe6b5
rename createCompressorLibraryFromProto to createCompressorFactoryFro…
Apr 14, 2020
da5a305
remove unused header
Apr 14, 2020
76c2b1f
docs: fix references
Apr 14, 2020
bc086c0
avoid using v2 types in v3 configs
Apr 15, 2020
3f89444
Merge remote-tracking branch 'upstream/master' into compress
Apr 15, 2020
801bdcf
fix comments
Apr 15, 2020
8e12669
restructure compressor library extensions
Apr 17, 2020
79ac3b9
Merge remote-tracking branch 'upstream/master' into compress
Apr 17, 2020
2bdbee3
run proto_format/proto_format.sh to fix format check
Apr 17, 2020
d72e015
finalize moving gzip code to new compression extension
Apr 20, 2020
85ae344
Merge remote-tracking branch 'upstream/master' into compress
Apr 20, 2020
d833c1a
run check_format.py fix
Apr 20, 2020
388d8bc
silence clang-tidy warnings
Apr 20, 2020
6ea514a
revert moving decompressor code to reduce patch size
Apr 21, 2020
d43fb14
add granularity to CODEOWNERS
Apr 21, 2020
1498c20
address review comments
Apr 21, 2020
4d09cd2
move gzip fuzzer test one level up
Apr 21, 2020
eabd93d
adjust silencing clang-tidy warnings
Apr 21, 2020
c69e0bb
compression: rework tests
Apr 22, 2020
63a6e46
compressor: add and use test mock for compressor
Apr 22, 2020
cf473a7
rename MockCompressorFilterConfig to TestCompressorFilterConfig
Apr 22, 2020
02024a3
compressor: drop gzip specific test from generic compressor
Apr 22, 2020
590167c
gzip: actually remove friend class
Apr 22, 2020
680ae29
resort to lvalue parameter to avoid usage after std::move casting
Apr 23, 2020
dd93ad6
test: set expectations of compress() call counts for every test case
Apr 23, 2020
e6f9c79
compressor: remove unused declaration from mock
Apr 23, 2020
9aaf9ff
compressor: add test case for CompressorFilterConfig
Apr 23, 2020
d9ee8e0
add compressor filter specific stats prefix
Apr 23, 2020
503c81a
fix code formatting
Apr 23, 2020
b3a49d2
Merge remote-tracking branch 'upstream/master' into compress
Apr 27, 2020
6ede080
drop removed component from CODEOWNERS
Apr 27, 2020
c5149d2
docs: fix doc title
Apr 27, 2020
9b59cac
run check_format.py fix
Apr 27, 2020
a271f28
gzip: do protobuf conversion with JSON round trip
Apr 27, 2020
bc77b25
run proto_format.sh fix
Apr 27, 2020
4a9bff7
reduce gzip compressor's stats prefix to just gzip
Apr 28, 2020
5f683bd
fix reference to the interface class
May 4, 2020
786ab77
avoid changing frozen API in gzip.proto
May 4, 2020
6a9b477
Merge remote-tracking branch 'upstream/master' into compress
May 4, 2020
4b4cfda
compressor: add stats_prefix to compressor filter
May 5, 2020
00fc997
Revert "compressor: add stats_prefix to compressor filter"
May 8, 2020
8c37ff1
Merge remote-tracking branch 'upstream/master' into compress
May 8, 2020
152a6b7
replace CompressorLibrary with TypedExtensionConfig
May 8, 2020
6b23035
reflect config changes in documentation
May 8, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion api/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,6 @@ proto_library(
"//envoy/extensions/common/dynamic_forward_proxy/v3:pkg",
"//envoy/extensions/common/ratelimit/v3:pkg",
"//envoy/extensions/common/tap/v3:pkg",
"//envoy/extensions/compression/common/compressor/v3:pkg",
"//envoy/extensions/compression/gzip/compressor/v3:pkg",
"//envoy/extensions/filters/common/fault/v3:pkg",
"//envoy/extensions/filters/http/adaptive_concurrency/v3:pkg",
Expand Down
9 changes: 0 additions & 9 deletions api/envoy/extensions/compression/common/compressor/v3/BUILD

This file was deleted.

This file was deleted.

1 change: 0 additions & 1 deletion api/envoy/extensions/filters/http/compressor/v3/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ api_proto_package(
deps = [
"//envoy/config/core/v3:pkg",
"//envoy/config/filter/http/compressor/v2:pkg",
"//envoy/extensions/compression/common/compressor/v3:pkg",
"@com_github_cncf_udpa//udpa/annotations:pkg",
],
)
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ syntax = "proto3";
package envoy.extensions.filters.http.compressor.v3;

import "envoy/config/core/v3/base.proto";
import "envoy/extensions/compression/common/compressor/v3/compressor.proto";
import "envoy/config/core/v3/extension.proto";

import "google/protobuf/any.proto";
import "google/protobuf/wrappers.proto";
Expand Down Expand Up @@ -56,5 +56,5 @@ message Compressor {
// :ref:`envoy.filters.http.compressor.gzip<envoy_api_msg_extensions.compression.gzip.compressor.v3.Gzip>`
// is included in Envoy.
// This field is ignored if used in the context of the gzip http-filter, but is mandatory otherwise.
compression.common.compressor.v3.CompressorLibrary compressor_library = 6;
config.core.v3.TypedExtensionConfig compressor_library = 6;
}
1 change: 0 additions & 1 deletion api/versioning/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ proto_library(
"//envoy/extensions/common/dynamic_forward_proxy/v3:pkg",
"//envoy/extensions/common/ratelimit/v3:pkg",
"//envoy/extensions/common/tap/v3:pkg",
"//envoy/extensions/compression/common/compressor/v3:pkg",
"//envoy/extensions/compression/gzip/compressor/v3:pkg",
"//envoy/extensions/filters/common/fault/v3:pkg",
"//envoy/extensions/filters/http/adaptive_concurrency/v3:pkg",
Expand Down
1 change: 0 additions & 1 deletion docs/root/api-v3/config/compression/compression.rst
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,4 @@ Compression
:glob:
:maxdepth: 2

../../extensions/compression/common/*/v3/*
../../extensions/compression/gzip/*/v3/*

This file was deleted.

This file was deleted.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,9 @@ CompressorFilterConfig::CompressorFilterConfig(
const std::string& stats_prefix, Stats::Scope& scope, Runtime::Loader& runtime,
Compression::Compressor::CompressorFactoryPtr compressor_factory)
: Common::Compressors::CompressorFilterConfig(
generic_compressor, stats_prefix + "compressor." + compressor_factory->statsPrefix(),
generic_compressor,
stats_prefix + "compressor." + generic_compressor.compressor_library().name() + "." +
compressor_factory->statsPrefix(),
scope, runtime, compressor_factory->contentEncoding()),
compressor_factory_(std::move(compressor_factory)) {}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@ class CompressorIntegrationTest : public testing::TestWithParam<Network::Address
- text/html
- application/json
compressor_library:
name: testlib
typed_config:
"@type": type.googleapis.com/envoy.extensions.compression.gzip.compressor.v3.Gzip
memory_level: 3
Expand All @@ -88,6 +89,7 @@ class CompressorIntegrationTest : public testing::TestWithParam<Network::Address
typed_config:
"@type": type.googleapis.com/envoy.extensions.filters.http.compressor.v3.Compressor
compressor_library:
name: testlib
typed_config:
"@type": type.googleapis.com/envoy.extensions.compression.gzip.compressor.v3.Gzip
)EOF"};
Expand Down