compression: create a decompressor extensibility point and move gzip decompressor

[junr03]

Description: this PR creates decompressors as an extension point and moves the zlib based gzip decompressor.
Risk Level: low - moving files around. None of the decompressor files were used in a public API capacity so nothing has to be deprecated.
Testing: all existing unit, integration, fuzz tests work.
Docs Changes: pending
Release Notes: pending

Progress toward #4445. Next PR would use this in a generic decompression filter a la #10553.

Signed-off-by: Jose Nino jnino@lyft.com

[repokitteh-read-only]

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to api/.

🐱

Caused by: #10744 was opened by junr03.

see: more, trace.

[htuch]

I think this is the decompression dual of #10553, which is currently under review (by you :) ). I'm good with making this an extension point, with the same proviso as in #10553, that we clearly state the deprecation considerations in the docs.

[junr03]

@htuch yep, this is the decompression dual to #10533. I got the idea for this proposal while reviewing #10533, and I am suggesting @rojkov updates #10533 to the organization proposed here (while keeping the necessary stuff around for proper deprecation).

This proposal basically takes @rojkov's work a bit further and gives compression top-level extension status. My proposal a) allows us to move the current code in source/common out; and b) does not embed the compression libraries within the filters/http tree, as compression libraries might be used outside of the context of the compressor and decompressor http filters.

[htuch]

@junr03 ack, makes sense. I actually prefer the organization that has the typed_config wrapper not inside common; it seems to make sense to have the base filter as a first-class entity, this isn't shared code.

[rebello95]

LGTM overall! Some minor suggestions

[stale]

This pull request has been automatically marked as stale because it has not had activity in the last 7 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

[junr03]

@rojkov, now that your PR is pretty much ready to merge, I have updated this PR for the decompressor side. Do you mind reviewing it?

[rojkov]

Looks great! I've found an inconsistency in my own PR even while looking at this one.

[repokitteh-read-only]

CC @envoyproxy/api-watchers: FYI only for changes made to api/.

🐱

Caused by: #10744 was synchronize by junr03.

see: more, trace.

[junr03]

@rojkov I updated this PR after merging yours on friday. PTAL when you can, thanks!

[rojkov]

This looks great! Just one note about auto-docs.

[junr03]

@rojkov updated!

[rojkov]

Thank you for fixing the title of compressor’s gzip.proto.
Looks good to me.

[junr03]

@mattklein123 this is ready for a pass from you

[mattklein123]

Nice!