Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking long word to stop content overflow. #10880

Merged
merged 2 commits into from
Apr 22, 2020

Conversation

mk46
Copy link
Contributor

@mk46 mk46 commented Apr 21, 2020

Signed-off-by: Manish Kumar manish.kumar1@india.nec.com

Fixed #10726

Signed-off-by: Manish Kumar <manish.kumar1@india.nec.com>
@mattklein123 mattklein123 self-assigned this Apr 21, 2020
@mattklein123
Copy link
Member

Thanks this is great. Do we want to bump the width slightly also? I would be fine with a small increase without going full screen. @moderation @lucperkins wdyt?

@mk46
Copy link
Contributor Author

mk46 commented Apr 22, 2020

@mattklein123 Default width is 800px. May I increase it to 1000px or other values?

@mattklein123
Copy link
Member

@mk46 yeah let's try 1000? @moderation WDYT?

@moderation
Copy link
Contributor

In the era of wide screens I'd vote for 1200 but would settle for 1000 as a first try 😄

@mattklein123
Copy link
Member

Can you fix DCO? Sorry.

/wait

Signed-off-by: Manish Kumar <manish.kumar1@india.nec.com>
Copy link
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mattklein123 mattklein123 merged commit 94f6797 into envoyproxy:master Apr 22, 2020
spenceral added a commit to spenceral/envoy that referenced this pull request Apr 23, 2020
Signed-off-by: Spencer Lewis <slewis@squareup.com>
* master: (46 commits)
  allow specifying the API version of bootstrap from the command line (envoyproxy#10803)
  config: adding connect matcher (unused) (envoyproxy#10894)
  Add missing dependency on `assert.h` (envoyproxy#10918)
  Lower heap and disk space used by kafka tests (envoyproxy#10915)
  [tools] handle commits merged without PR in deprecated script (envoyproxy#10723)
  tools: including working tree in modified_since_last_github_commit.sh diff. (envoyproxy#10911)
  rocketmq_proxy: implement rocketmq proxy
  [docs] PR template to include commit message (envoyproxy#10900)
  docs: breaking long word to stop content overflow. (envoyproxy#10880)
  Delete legacy connection pool code. (envoyproxy#10881)
  wasm: clarify how configuration is passed (envoyproxy#10782)
  issue template: clarify security/crash reporting (envoyproxy#10885)
  api/faq: add entry on incremental xDS. (envoyproxy#10876)
  router: retry overloaded requests (envoyproxy#10847)
  Remove inclusion of pthread.h, not needed for linux compilation (envoyproxy#10895)
  request_id: Add option to always set request id in response (envoyproxy#10808)
  xray: Use correct types for segment document output (envoyproxy#10834)
  router: fixing a watermark bug for streaming retries (envoyproxy#10866)
  http: auditing Path() calls for safety with Pathless CONNECT (envoyproxy#10851)
  Remove hardcoded type urls Part.2 (envoyproxy#10848)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: content width issue
3 participants