-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows: Enable now-passing unit tests #12343
Windows: Enable now-passing unit tests #12343
Conversation
Logs from latest run: https://dev.azure.com/cncf/4684fb3d-0389-4e0b-8251-221942316e06/_apis/build/builds/46650/logs/81
|
Set to reviewable just to get CI to run |
Signed-off-by: William A Rowe Jr <wrowe@vmware.com> Co-authored-by: Sunjay Bhatia <sunjayb@vmware.com>
This PR is now ready for review, we will move debugging integration tests into another PR |
The remaining non-integration tests that are failing are:
|
Lizan -- this is pretty trivial but can you give it a @envoyproxy/senior-maintainers stamp of approval? |
@jmarantz - not only trivial. It's a no-op on Linux, macOS, iOS and Android. |
Commit Message:
Windows: Enable now-passing unit tests
This pass only enables passing unit tests, integration tests have been flaky and are being worked on in a separate effort.
Enabled tests:
Additional Description: N/A
Risk Level: Low
Testing: Validated tests passing locally and via RBE
Docs Changes: N/A
Release Notes: N/A