Fixes grpc tests on Windows #12433
Merged
Fixes grpc tests on Windows #12433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: davinci26 <sotirisnan@gmail.com>
Signed-off-by: davinci26 <sotirisnan@gmail.com>
|
@envoyproxy/windows-dev |
lizan
reviewed
Aug 3, 2020
|
@lizan I have format errors on the autogenerated files header files (that contain the hashes). Should I also fixed or should we ignore them from the formatting rule? |
|
@davinci26 format check is required for all checked-in files regardless whether they are generated or not. run fix_format and you should be good. |
davinci26
commented
Aug 4, 2020
Signed-off-by: Sotiris Nanopoulos <sonanopo@microsoft.com>
Signed-off-by: Sotiris Nanopoulos <sonanopo@microsoft.com>
|
@lizan this is ready for another review |
jrajahalme
added a commit
to cilium/proxy
that referenced
this pull request
Dec 18, 2020
Refresh test certificates by backporting upstream commit 276c978576b252f0f20d8531fe9dd90d966ede42 (PR envoyproxy/envoy#12433). Signed-off-by: Jarno Rajahalme <jarno@covalent.io>
jrajahalme
added a commit
to cilium/proxy
that referenced
this pull request
Dec 22, 2020
Refresh test certificates by backporting upstream commit 276c978576b252f0f20d8531fe9dd90d966ede42 (PR envoyproxy/envoy#12433). Signed-off-by: Jarno Rajahalme <jarno@covalent.io>
cpakulski
pushed a commit
to cpakulski/envoy
that referenced
this pull request
Jan 7, 2021
1. Adds localhost to the upstreamcert.cfg 2. Makes fake_upstream TcpListenerSocket connect to the localhost instead of any address. 3. GRPC tests are no longer failing on windows. Risk Level: Low Testing: N/A Signed-off-by: Sotiris Nanopoulos <sonanopo@microsoft.com> Signed-off-by: Christoph Pakulski <christoph@tetrate.io>
cpakulski
pushed a commit
to cpakulski/envoy
that referenced
this pull request
Jan 7, 2021
1. Adds localhost to the upstreamcert.cfg 2. Makes fake_upstream TcpListenerSocket connect to the localhost instead of any address. 3. GRPC tests are no longer failing on windows. Risk Level: Low Testing: N/A Signed-off-by: Sotiris Nanopoulos <sonanopo@microsoft.com> Signed-off-by: Christoph Pakulski <christoph@tetrate.io>
alyssawilk
pushed a commit
that referenced
this pull request
Jan 7, 2021
1. Adds localhost to the upstreamcert.cfg 2. Makes fake_upstream TcpListenerSocket connect to the localhost instead of any address. 3. GRPC tests are no longer failing on windows. Risk Level: Low Testing: N/A Signed-off-by: Sotiris Nanopoulos <sonanopo@microsoft.com> Signed-off-by: Christoph Pakulski <christoph@tetrate.io> Co-authored-by: Sotiris Nanopoulos <sonanopo@microsoft.com>
alyssawilk
pushed a commit
that referenced
this pull request
Jan 7, 2021
1. Adds localhost to the upstreamcert.cfg 2. Makes fake_upstream TcpListenerSocket connect to the localhost instead of any address. 3. GRPC tests are no longer failing on windows. Risk Level: Low Testing: N/A Signed-off-by: Sotiris Nanopoulos <sonanopo@microsoft.com> Signed-off-by: Christoph Pakulski <christoph@tetrate.io> Co-authored-by: Sotiris Nanopoulos <sonanopo@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sotiris Nanopoulos sonanopo@microsoft.com
Commit Message:
upstreamcert.cfgfake_upstreamTcpListenerSocketconnect to the localhost instead of any address.Additional Description:
Risk Level: Low
Testing: N/A
Docs Changes: N/A
Release Notes: N/A