Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: track simulated timers per dispatcher to simplify thread interactions and locking #12614

Closed
wants to merge 8 commits into from

Conversation

jmarantz
Copy link
Contributor

For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md

Commit Message:
Direct copy of @antoniovicente 's #12609 , with format fixed (one spelling dict add).
#Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]

Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
@jmarantz
Copy link
Contributor Author

After having merged in Matt's changes to de-flake integration tests, 3 fail locally for me in fastbuild with this PR:

//test/extensions/filters/http/fault:fault_filter_integration_test      TIMEOUT in 315.1s
//test/integration:http_timeout_integration_test                        TIMEOUT in 315.1s
//test/server:guarddog_impl_test                                         FAILED in 17.1s

One possible place to look is SimulatedTimeSystemHelper::SimulatedScheduler::runReadyAlarms and avd's comment:

  // TODO delay alarms scheduled this iteration until next iteration.

or it could just be test bugs we were getting away with before.

@jmarantz
Copy link
Contributor Author

closing this for now in favor of Antonio's pr

@jmarantz jmarantz closed this Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants