network: add tcp listener backlog config #12625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florin Coras <fcoras@cisco.com>
mattklein123
requested changes
Aug 13, 2020
include/envoy/event/dispatcher.h
Outdated
| Network::ListenerCallbacks& cb, | ||
| bool bind_to_port) PURE; | ||
| Network::ListenerCallbacks& cb, bool bind_to_port, | ||
| uint32_t backlog_size = ENVOY_TCP_BACKLOG_SIZE) PURE; |
There was a problem hiding this comment.
Can we not have a default param on this interface? I would prefer that we make sure we hit all call sites. How many other places need to change?
There was a problem hiding this comment.
It's definitely possible because the first version of the patch didn't use a default param :-). It's a decent amount of tests, but if you're okay with that, I can push an update.
| @@ -25,6 +25,7 @@ class ListenerImpl : public BaseListenerImpl { | |||
| void setupServerSocket(Event::DispatcherImpl& dispatcher, Socket& socket); | |||
|
|
|||
| ListenerCallbacks& cb_; | |||
| uint32_t backlog_size_; | |||
|
Windows and arm seem to be failing consistently but with timeouts in unexpected places e.g., |
|
There are various flakes that are being worked on. See #12527. I will rerun. |
|
Thanks, @mattklein123! |
mpuncel
added a commit
to mpuncel/envoy
that referenced
this pull request
Aug 14, 2020
* master: (67 commits) logger: support log control in admin interface and command line option for Fancy Logger (envoyproxy#12369) test: fix http_timeout_integration_test flake (envoyproxy#12654) [fuzz]added an input check in writefilter fuzzer and added test cases (envoyproxy#12628) add 'explicit' restriction. (envoyproxy#12643) scoped_rds_integration_test migrate from api v2 to api v3. (envoyproxy#12633) fuzz: added fuzz test for listener filter tls_inspector (envoyproxy#12617) testing: fix multiple race conditions in simulated time tests (envoyproxy#12527) [tls] Move handshaking behavior into SslSocketInfo. (envoyproxy#12571) header: getting rid of exception-throwing behaviors in header files [the rest] (envoyproxy#12611) router: add new ratelimited retry backoff strategy (envoyproxy#12202) [redis_proxy] added a constraint for route.prefix().size() (envoyproxy#12637) network: add tcp listener backlog config (envoyproxy#12625) runtime: debug log that condition is always true when fractionalPercent numerator > denominator (envoyproxy#12068) WatchDog Extension hook (envoyproxy#12416) router: add dynamic metadata header formatter (envoyproxy#11858) statsd: revert visibility to public (envoyproxy#12621) Fix regression of /build_* in gitignore (envoyproxy#12630) Added a missing extension point to documentation. (envoyproxy#12620) Reverts proxy protocol test on windows (envoyproxy#12619) caching: Improved the tests and coverage of the CacheFilter tree (envoyproxy#12544) ... Signed-off-by: Michael Puncel <mpuncel@squareup.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Florin Coras fcoras@cisco.com
Risk Level: Low
Testing: unit tests
Docs Changes: n/a
Release Notes: n/a