envoyproxy · mattklein123 · Aug 18, 2020 · Aug 11, 2020 · Aug 18, 2020 · Aug 18, 2020
diff --git a/ci/windows_ci_steps.sh b/ci/windows_ci_steps.sh
@@ -28,10 +28,19 @@ BAZEL_STARTUP_OPTIONS="--output_base=c:/_eb"
 BAZEL_BUILD_OPTIONS="-c opt --config=msvc-cl --show_task_finish --verbose_failures \
   --test_output=errors ${BAZEL_BUILD_EXTRA_OPTIONS} ${BAZEL_EXTRA_TEST_OPTIONS}"
 
-bazel ${BAZEL_STARTUP_OPTIONS} build ${BAZEL_BUILD_OPTIONS} //source/exe:envoy-static --build_tag_filters=-skip_on_windows
+# Test to validate updates of all dependency libraries in bazel/external and bazel/foreign_cc
+# bazel ${BAZEL_STARTUP_OPTIONS} build ${BAZEL_BUILD_OPTIONS} //bazel/... --build_tag_filters=-skip_on_windows
+
+# Complete envoy-static build (nothing needs to be skipped, build failure indicates broken dependencies)
+bazel ${BAZEL_STARTUP_OPTIONS} build ${BAZEL_BUILD_OPTIONS} //source/exe:envoy-static
 
 # Test invocations of known-working tests on Windows
-bazel ${BAZEL_STARTUP_OPTIONS} test ${BAZEL_BUILD_OPTIONS} //test/... --test_tag_filters=-skip_on_windows,-fails_on_windows --build_tests_only
+bazel ${BAZEL_STARTUP_OPTIONS} test ${BAZEL_BUILD_OPTIONS} //test/... --test_tag_filters=-skip_on_windows,-fails_on_windows,-flaky_on_windows --build_tests_only
+
+# Build tests that are known-flaky or known-failing to ensure no compilation regressions
+bazel ${BAZEL_STARTUP_OPTIONS} build ${BAZEL_BUILD_OPTIONS} //test/... --test_tag_filters=-skip_on_windows,fails_on_windows,flaky_on_windows --build_tests_only
 
-# Build tests that are failing to ensure no regressions
-bazel ${BAZEL_STARTUP_OPTIONS} build ${BAZEL_BUILD_OPTIONS} //test/... --test_tag_filters=-skip_on_windows,fails_on_windows --build_tests_only
+# Summarize tests bypasssed to monitor the progress of porting to Windows
+echo Tests bypassed as skip_on_windows: `bazel query 'kind(".*test rule", attr("tags", "skip_on_windows", //test/...))' 2>/dev/null | sort | wc -l` known unbuildable or inapplicable tests
+echo Tests bypassed as fails_on_windows: `bazel query 'kind(".*test rule", attr("tags", "fails_on_windows", //test/...))' 2>/dev/null | sort | wc -l` known incompatible tests
+echo Tests bypassed as flaky_on_windows: `bazel query 'kind(".*test rule", attr("tags", "flaky_on_windows", //test/...))' 2>/dev/null | sort | wc -l` known unstable tests
diff --git a/test/extensions/access_loggers/grpc/BUILD b/test/extensions/access_loggers/grpc/BUILD
@@ -78,7 +78,6 @@ envoy_extension_cc_test(
     name = "http_grpc_access_log_integration_test",
     srcs = ["http_grpc_access_log_integration_test.cc"],
     extension_name = "envoy.access_loggers.http_grpc",
-    tags = ["fails_on_windows"],
     deps = [
         "//source/common/buffer:zero_copy_input_stream_lib",
         "//source/common/grpc:codec_lib",
@@ -98,7 +97,6 @@ envoy_extension_cc_test(
     name = "tcp_grpc_access_log_integration_test",
     srcs = ["tcp_grpc_access_log_integration_test.cc"],
     extension_name = "envoy.access_loggers.http_grpc",
-    tags = ["fails_on_windows"],
     deps = [
         "//source/common/buffer:zero_copy_input_stream_lib",
         "//source/common/grpc:codec_lib",

diff --git a/test/extensions/clusters/aggregate/BUILD b/test/extensions/clusters/aggregate/BUILD
@@ -54,7 +54,6 @@ envoy_extension_cc_test(
     name = "cluster_integration_test",
     srcs = ["cluster_integration_test.cc"],
     extension_name = "envoy.clusters.aggregate",
-    tags = ["fails_on_windows"],
     deps = [
         "//source/common/config:protobuf_link_hacks",
         "//source/common/protobuf:utility_lib",

diff --git a/test/extensions/common/aws/BUILD b/test/extensions/common/aws/BUILD
@@ -76,7 +76,6 @@ envoy_cc_test(
     srcs = [
         "aws_metadata_fetcher_integration_test.cc",
     ],
-    tags = ["fails_on_windows"],
     deps = [
         "//source/common/common:fmt_lib",
         "//source/extensions/common/aws:utility_lib",

diff --git a/test/extensions/filters/http/adaptive_concurrency/BUILD b/test/extensions/filters/http/adaptive_concurrency/BUILD
@@ -34,7 +34,6 @@ envoy_extension_cc_test(
         "adaptive_concurrency_filter_integration_test.h",
     ],
     extension_name = "envoy.filters.http.adaptive_concurrency",
-    tags = ["fails_on_windows"],
     deps = [
         "//source/extensions/filters/http/adaptive_concurrency:config",
         "//source/extensions/filters/http/fault:config",

diff --git a/test/extensions/filters/http/admission_control/BUILD b/test/extensions/filters/http/admission_control/BUILD
@@ -60,7 +60,6 @@ envoy_extension_cc_test(
     name = "admission_control_integration_test",
     srcs = ["admission_control_integration_test.cc"],
     extension_name = "envoy.filters.http.admission_control",
-    tags = ["fails_on_windows"],
     deps = [
         "//source/extensions/filters/http/admission_control:config",
         "//test/integration:http_integration_lib",

diff --git a/test/extensions/filters/http/aws_lambda/BUILD b/test/extensions/filters/http/aws_lambda/BUILD
@@ -27,7 +27,6 @@ envoy_extension_cc_test(
     name = "aws_lambda_filter_integration_test",
     srcs = ["aws_lambda_filter_integration_test.cc"],
     extension_name = "envoy.filters.http.aws_lambda",
-    tags = ["fails_on_windows"],
     deps = [
         "//source/common/http:header_map_lib",
         "//source/extensions/filters/http/aws_lambda:aws_lambda_filter_lib",

diff --git a/test/extensions/filters/http/buffer/BUILD b/test/extensions/filters/http/buffer/BUILD
@@ -36,7 +36,6 @@ envoy_extension_cc_test(
     name = "buffer_filter_integration_test",
     srcs = ["buffer_filter_integration_test.cc"],
     extension_name = "envoy.filters.http.buffer",
-    tags = ["fails_on_windows"],
     deps = [
         "//source/extensions/filters/http/buffer:config",
         "//test/config:utility_lib",

diff --git a/test/extensions/filters/http/compressor/BUILD b/test/extensions/filters/http/compressor/BUILD
@@ -32,7 +32,6 @@ envoy_extension_cc_test(
         "compressor_filter_integration_test.cc",
     ],
     extension_name = "envoy.filters.http.compressor",
-    tags = ["fails_on_windows"],
     deps = [
         "//source/extensions/compression/gzip/compressor:config",
         "//source/extensions/compression/gzip/decompressor:config",

diff --git a/test/extensions/filters/http/cors/BUILD b/test/extensions/filters/http/cors/BUILD
@@ -30,7 +30,6 @@ envoy_extension_cc_test(
     name = "cors_filter_integration_test",
     srcs = ["cors_filter_integration_test.cc"],
     extension_name = "envoy.filters.http.cors",
-    tags = ["fails_on_windows"],
     deps = [
         "//source/common/buffer:buffer_lib",
         "//source/common/http:header_map_lib",

diff --git a/test/extensions/filters/http/csrf/BUILD b/test/extensions/filters/http/csrf/BUILD
@@ -31,7 +31,6 @@ envoy_extension_cc_test(
     name = "csrf_filter_integration_test",
     srcs = ["csrf_filter_integration_test.cc"],
     extension_name = "envoy.filters.http.csrf",
-    tags = ["fails_on_windows"],
     deps = [
         "//source/extensions/filters/http/csrf:config",
         "//test/config:utility_lib",

diff --git a/test/extensions/filters/http/decompressor/BUILD b/test/extensions/filters/http/decompressor/BUILD
@@ -36,7 +36,6 @@ envoy_extension_cc_test(
         "decompressor_filter_integration_test.cc",
     ],
     extension_name = "envoy.filters.http.decompressor",
-    tags = ["fails_on_windows"],
     deps = [
         "//source/extensions/compression/gzip/compressor:config",
         "//source/extensions/compression/gzip/decompressor:config",

diff --git a/test/extensions/filters/http/dynamic_forward_proxy/BUILD b/test/extensions/filters/http/dynamic_forward_proxy/BUILD
@@ -37,7 +37,7 @@ envoy_extension_cc_test(
         "//test/config/integration/certs",
     ],
     extension_name = "envoy.filters.http.dynamic_forward_proxy",
-    tags = ["fails_on_windows"],
+    tags = ["flaky_on_windows"],
     deps = [
         "//source/extensions/clusters/dynamic_forward_proxy:cluster",
         "//source/extensions/filters/http/dynamic_forward_proxy:config",

diff --git a/test/extensions/filters/http/ext_authz/BUILD b/test/extensions/filters/http/ext_authz/BUILD
@@ -57,7 +57,7 @@ envoy_extension_cc_test(
     name = "ext_authz_integration_test",
     srcs = ["ext_authz_integration_test.cc"],
     extension_name = "envoy.filters.http.ext_authz",
-    tags = ["fails_on_windows"],
+    tags = ["flaky_on_windows"],
     deps = [
         "//source/extensions/filters/http/ext_authz:config",
         "//test/integration:http_integration_lib",

diff --git a/test/extensions/filters/http/fault/BUILD b/test/extensions/filters/http/fault/BUILD
@@ -54,7 +54,6 @@ envoy_extension_cc_test(
     name = "fault_filter_integration_test",
     srcs = ["fault_filter_integration_test.cc"],
     extension_name = "envoy.filters.http.fault",
-    tags = ["fails_on_windows"],
     deps = [
         "//source/extensions/filters/http/fault:config",
         "//test/integration:http_protocol_integration_lib",

diff --git a/test/extensions/filters/http/grpc_http1_reverse_bridge/BUILD b/test/extensions/filters/http/grpc_http1_reverse_bridge/BUILD
@@ -28,7 +28,6 @@ envoy_extension_cc_test(
     name = "reverse_bridge_integration_test",
     srcs = ["reverse_bridge_integration_test.cc"],
     extension_name = "envoy.filters.http.grpc_http1_reverse_bridge",
-    tags = ["fails_on_windows"],
     deps = [
         "//source/common/buffer:buffer_lib",
         "//source/common/http:header_map_lib",

diff --git a/test/extensions/filters/http/grpc_json_transcoder/BUILD b/test/extensions/filters/http/grpc_json_transcoder/BUILD
@@ -61,7 +61,6 @@ envoy_extension_cc_test(
         "//test/proto:bookstore_proto_descriptor",
     ],
     extension_name = "envoy.filters.http.grpc_json_transcoder",
-    tags = ["fails_on_windows"],
     deps = [
         "//source/common/grpc:codec_lib",
         "//source/common/http:header_map_lib",

diff --git a/test/extensions/filters/http/grpc_web/BUILD b/test/extensions/filters/http/grpc_web/BUILD
@@ -39,7 +39,6 @@ envoy_extension_cc_test(
     name = "grpc_web_integration_test",
     srcs = ["grpc_web_filter_integration_test.cc"],
     extension_name = "envoy.filters.http.grpc_web",
-    tags = ["fails_on_windows"],
     deps = [
         "//source/common/buffer:buffer_lib",
         "//source/common/http:header_map_lib",

diff --git a/test/extensions/filters/http/gzip/BUILD b/test/extensions/filters/http/gzip/BUILD
@@ -36,7 +36,6 @@ envoy_extension_cc_test(
         "gzip_filter_integration_test.cc",
     ],
     extension_name = "envoy.filters.http.gzip",
-    tags = ["fails_on_windows"],
     deps = [
         "//source/extensions/compression/gzip/decompressor:zlib_decompressor_impl_lib",
         "//source/extensions/filters/http/gzip:config",

diff --git a/test/extensions/filters/http/jwt_authn/BUILD b/test/extensions/filters/http/jwt_authn/BUILD
@@ -117,7 +117,6 @@ envoy_extension_cc_test(
     name = "filter_integration_test",
     srcs = ["filter_integration_test.cc"],
     extension_name = "envoy.filters.http.jwt_authn",
-    tags = ["fails_on_windows"],
     deps = [
         "//source/common/router:string_accessor_lib",
         "//source/extensions/filters/http/common:pass_through_filter_lib",

diff --git a/test/extensions/filters/http/ratelimit/BUILD b/test/extensions/filters/http/ratelimit/BUILD
@@ -52,7 +52,7 @@ envoy_extension_cc_test(
     name = "ratelimit_integration_test",
     srcs = ["ratelimit_integration_test.cc"],
     extension_name = "envoy.filters.http.ratelimit",
-    tags = ["fails_on_windows"],
+    tags = ["flaky_on_windows"],
     deps = [
         "//source/common/buffer:zero_copy_input_stream_lib",
         "//source/common/grpc:codec_lib",

diff --git a/test/extensions/filters/http/rbac/BUILD b/test/extensions/filters/http/rbac/BUILD
@@ -45,7 +45,6 @@ envoy_extension_cc_test(
     name = "rbac_filter_integration_test",
     srcs = ["rbac_filter_integration_test.cc"],
     extension_name = "envoy.filters.http.rbac",
-    tags = ["fails_on_windows"],
     deps = [
         "//source/extensions/filters/http/rbac:config",
         "//test/config:utility_lib",

diff --git a/test/extensions/filters/http/router/BUILD b/test/extensions/filters/http/router/BUILD
@@ -30,7 +30,6 @@ envoy_extension_cc_test(
         "//test/config/integration/certs",
     ],
     extension_name = "envoy.filters.http.router",
-    tags = ["fails_on_windows"],
     deps = [
         "//source/extensions/filters/http/router:config",
         "//test/integration:http_integration_lib",

diff --git a/test/extensions/filters/http/squash/BUILD b/test/extensions/filters/http/squash/BUILD
@@ -32,7 +32,6 @@ envoy_extension_cc_test(
     name = "squash_filter_integration_test",
     srcs = ["squash_filter_integration_test.cc"],
     extension_name = "envoy.filters.http.squash",
-    tags = ["fails_on_windows"],
     deps = [
         "//source/extensions/filters/http/squash:config",
         "//test/integration:http_integration_lib",

diff --git a/test/extensions/filters/http/tap/BUILD b/test/extensions/filters/http/tap/BUILD
@@ -52,7 +52,6 @@ envoy_extension_cc_test(
     name = "tap_filter_integration_test",
     srcs = ["tap_filter_integration_test.cc"],
     extension_name = "envoy.filters.http.tap",
-    tags = ["fails_on_windows"],
     deps = [
         "//source/extensions/filters/http/tap:config",
         "//test/integration:http_integration_lib",

diff --git a/test/extensions/filters/network/local_ratelimit/BUILD b/test/extensions/filters/network/local_ratelimit/BUILD
@@ -30,7 +30,6 @@ envoy_extension_cc_test(
     name = "local_ratelimit_integration_test",
     srcs = ["local_ratelimit_integration_test.cc"],
     extension_name = "envoy.filters.network.local_ratelimit",
-    tags = ["fails_on_windows"],
     deps = [
         "//source/extensions/filters/network/local_ratelimit:config",
         "//source/extensions/filters/network/tcp_proxy:config",

diff --git a/test/extensions/filters/network/postgres_proxy/BUILD b/test/extensions/filters/network/postgres_proxy/BUILD
@@ -57,7 +57,6 @@ envoy_extension_cc_test(
         "postgres_test_config.yaml",
     ],
     extension_name = "envoy.filters.network.postgres_proxy",
-    tags = ["fails_on_windows"],
     deps = [
         "//source/common/tcp_proxy",
         "//source/extensions/filters/network/postgres_proxy:config",

diff --git a/test/extensions/filters/network/rbac/BUILD b/test/extensions/filters/network/rbac/BUILD
@@ -41,7 +41,6 @@ envoy_extension_cc_test(
     name = "integration_test",
     srcs = ["integration_test.cc"],
     extension_name = "envoy.filters.network.rbac",
-    tags = ["fails_on_windows"],
     deps = [
         "//source/extensions/filters/network/echo:config",
         "//source/extensions/filters/network/rbac:config",

diff --git a/test/extensions/filters/network/redis_proxy/BUILD b/test/extensions/filters/network/redis_proxy/BUILD
@@ -153,7 +153,6 @@ envoy_extension_cc_test(
     name = "redis_proxy_integration_test",
     srcs = ["redis_proxy_integration_test.cc"],
     extension_name = "envoy.filters.network.redis_proxy",
-    tags = ["fails_on_windows"],
     deps = [
         "//source/extensions/filters/network/common/redis:fault_lib",
         "//source/extensions/filters/network/redis_proxy:config",

diff --git a/test/extensions/filters/network/sni_dynamic_forward_proxy/BUILD b/test/extensions/filters/network/sni_dynamic_forward_proxy/BUILD
@@ -32,7 +32,6 @@ envoy_extension_cc_test(
         "//test/config/integration/certs",
     ],
     extension_name = "envoy.filters.network.sni_dynamic_forward_proxy",
-    tags = ["fails_on_windows"],
     deps = [
         "//source/extensions/clusters/dynamic_forward_proxy:cluster",
         "//source/extensions/filters/listener/tls_inspector:config",

diff --git a/test/extensions/grpc_credentials/file_based_metadata/BUILD b/test/extensions/grpc_credentials/file_based_metadata/BUILD
@@ -13,6 +13,7 @@ envoy_cc_test(
     name = "file_based_metadata_grpc_credentials_test",
     srcs = ["file_based_metadata_grpc_credentials_test.cc"],
     data = ["//test/config/integration/certs"],
+    tags = ["flaky_on_windows"],
     deps = [
         "//source/extensions/grpc_credentials:well_known_names",
         "//source/extensions/grpc_credentials/file_based_metadata:config",

diff --git a/test/extensions/stats_sinks/hystrix/BUILD b/test/extensions/stats_sinks/hystrix/BUILD
@@ -46,7 +46,6 @@ envoy_extension_cc_test(
     name = "hystrix_integration_test",
     srcs = ["hystrix_integration_test.cc"],
     extension_name = "envoy.stat_sinks.hystrix",
-    tags = ["fails_on_windows"],
     deps = [
         "//source/extensions/stat_sinks/hystrix:config",
         "//test/integration:http_protocol_integration_lib",

diff --git a/test/extensions/stats_sinks/metrics_service/BUILD b/test/extensions/stats_sinks/metrics_service/BUILD
@@ -45,7 +45,7 @@ envoy_extension_cc_test(
     name = "metrics_service_integration_test",
     srcs = ["metrics_service_integration_test.cc"],
     extension_name = "envoy.stat_sinks.metrics_service",
-    tags = ["fails_on_windows"],
+    tags = ["flaky_on_windows"],
     deps = [
         "//source/common/buffer:zero_copy_input_stream_lib",
         "//source/common/grpc:codec_lib",

diff --git a/test/extensions/transport_sockets/alts/BUILD b/test/extensions/transport_sockets/alts/BUILD
@@ -79,7 +79,6 @@ envoy_extension_cc_test(
         "grpc_alts_handshaker_proto",
         "grpc_alts_transport_security_common_proto",
     ],
-    tags = ["fails_on_windows"],
     deps = [
         "//source/common/common:utility_lib",
         "//source/common/event:dispatcher_includes",

diff --git a/test/extensions/transport_sockets/tls/integration/BUILD b/test/extensions/transport_sockets/tls/integration/BUILD
@@ -17,7 +17,6 @@ envoy_cc_test(
     data = [
         "//test/config/integration/certs",
     ],
-    tags = ["fails_on_windows"],
     deps = [
         "//source/common/event:dispatcher_includes",
         "//source/common/event:dispatcher_lib",